[Fix] jsx-newline: jsx-newline breaking with comments

jsx-eslint · May 31, 2024 · 7722f49 · 7722f49
1 parent e27ef81
commit 7722f49
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/lib/rules/jsx-newline.js b/lib/rules/jsx-newline.js
@@ -21,7 +21,9 @@ const messages = {
 };
 
 function isMultilined(node) {
-  return node && node.loc.start.line !== node.loc.end.line;
+  if (node) {
+    return node.loc.start.line !== node.loc.end.line;
+  }
 }
 
 /** @type {import('eslint').Rule.RuleModule} */

diff --git a/tests/lib/rules/jsx-newline.js b/tests/lib/rules/jsx-newline.js
@@ -203,6 +203,19 @@ new RuleTester({ parserOptions }).run('jsx-newline', rule, {
       `,
       options: [{ prevent: true, allowMultilines: true }],
     },
+    {
+      code: `
+        function Test() {
+          return (
+            <div>
+              <div />
+              {/* a comment */}
+            </div>
+          );
+        }
+      `,
+      options: [{ prevent: true, allowMultilines: true }],
+    },
   ]),
   invalid: parsers.all([
     {