Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check Producer safety #82

Open
judwhite opened this issue Oct 17, 2016 · 0 comments
Open

Check Producer safety #82

judwhite opened this issue Oct 17, 2016 · 0 comments
Labels
chore

Comments

@judwhite
Copy link
Owner

Check:

  • _transactionChan
  • _transactions
  • _conn.WriteCommand
  • _responseChan
  • _errorChan, _closeChan, _exitChan

for any possible race conditions.

We need to guarantee that the OK received from nsqd for a PUB really belongs to the PUB that was sent.

May need to create a modified nsqd to accept/return a correlation id to verify this behavior under stress.

Note: This isn't currently thought to be a problem, but there's a lot of indirection when it comes to PUB and the underlying network stream.
@judwhite judwhite added the chore label Oct 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@judwhite