Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make NsqSharp .Net Core compatible #84

Open
michiski opened this issue Nov 18, 2016 · 5 comments
Open

Make NsqSharp .Net Core compatible #84

michiski opened this issue Nov 18, 2016 · 5 comments

Comments

@michiski
Copy link

Hi, are there any plans to make your project .Net Core compatible?

@judwhite
Copy link
Owner

@michiski Yes, if it's possible without interfering too much with the regular .NET build. I still need to get up to speed on the latest with .NET Core. Last time I spoke with someone from Microsoft they were planning on adding support for ServiceBase but it wasn't ready yet; not sure how that's changed.

@tomc974
Copy link

tomc974 commented Jan 26, 2018

Hi,

Are there any chance for this enhancement to be implemented in the coming months? I may have a need for an NSQ driver for a .NET Core 2.0 / .NET Standard 2.0 project.

As for ServiceBase, since this is a Windows-only feature, it probably never will be a part of neither .NET Core 2.0 nor .NET Standard 2.0. My suggestion would be to split the NsqSharp project into two sub-projects (driver and bus) but this may be quite some work for you...

@matteocontrini
Copy link

ServiceBase is going to be made available (for Windows only) in .NET Core through the Windows Compatibility Pack, scheduled to be released together with .NET Core 2.1

https://blogs.msdn.microsoft.com/dotnet/2017/11/16/announcing-the-windows-compatibility-pack-for-net-core/

@judwhite
Copy link
Owner

@matteocontrini Thanks. Glad to see it's going to make it for Windows eventually. I'll probably end up doing something like https://github.com/judwhite/go-svc/blob/master/svc/svc_other.go and https://github.com/judwhite/go-svc/blob/master/svc/svc_windows.go with build tags to get a common interface across platforms, or use a plugin-like approach to achieve the same goal.

@crazybert has PR #91 started for .NET Core support.

@julealgon
Copy link

Hey @judwhite , are there any blockers to have a compilation target for .Net Core here still? We are facing a warning in one of our core projects due to this problem:

Severity Code Description Project File Line Suppression State
Warning NU1701 Package 'NsqSharp 0.5.4' was restored using '.NETFramework,Version=v4.6.1' instead of the project target framework '.NETCoreApp,Version=v2.0'. This package may not be fully compatible with your project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants