Make file handling more robust

Author: davidanthoff

Project.toml

@@ -26,7 +26,7 @@ JSONRPC = "1.1"
 JuliaFormatter = "0.20.0, 0.21, 0.22, 0.23, 1"
 PrecompileTools = "1"
 StaticLint = "8.0"
-JuliaWorkspaces = "4.5"
+JuliaWorkspaces = "4.6"
 SymbolServer = "8"
 Tokenize = "0.5.10"
 URIs = "1.3"

src/requests/init.jl

@@ -203,7 +203,7 @@ function initialized_notification(params::InitializedParams, server::LanguageSer
 
     if server.workspaceFolders !== nothing
         for i in server.workspaceFolders
-            files = JuliaWorkspaces.read_path_into_textdocuments(filepath2uri(i))
+            files = JuliaWorkspaces.read_path_into_textdocuments(filepath2uri(i), ignore_io_errors=true)
 
             for i in files
                 # This might be a sub folder of a folder that is already watched
@@ -230,7 +230,9 @@ function initialized_notification(params::InitializedParams, server::LanguageSer
                             error("This should not happen")
                         end
 
-                        text_file = JuliaWorkspaces.read_text_file_from_uri(uri)
+                        text_file = JuliaWorkspaces.read_text_file_from_uri(uri, return_nothing_on_io_error=true)
+                        text_file === nothing || continue
+
                         server._files_from_disc[uri] = text_file
 
                         if !haskey(server._open_file_versions, uri)

src/requests/misc.jl

@@ -94,7 +94,9 @@ function julia_activateenvironment_notification(params::NamedTuple{(:envPath,),T
                             error("This should not happen")
                         end
 
-                        text_file = JuliaWorkspaces.read_text_file_from_uri(uri)
+                        text_file = JuliaWorkspaces.read_text_file_from_uri(uri, return_nothing_on_io_error=true)
+                        text_file===nothing || continue
+
                         server._files_from_disc[uri] = text_file
 
                         if !haskey(server._open_file_versions, uri)

src/requests/workspace.jl

@@ -10,14 +10,7 @@ function workspace_didChangeWatchedFiles_notification(params::DidChangeWatchedFi
         uri.scheme=="file" || continue
 
         if change.type == FileChangeTypes.Created || change.type == FileChangeTypes.Changed
-            text_file = nothing
-            try
-                JuliaWorkspaces.read_text_file_from_uri(uri)
-            catch err
-                if !(is_walkdir_error(err) || err isa JuliaWorkspaces.JWInvalidFileContent)
-                    rethrow(err)
-                end
-            end
+            text_file = JuliaWorkspaces.read_text_file_from_uri(uri, return_nothing_on_io_error=true)
 
             # First handle case where fild could not be found or has invalid content
             if text_file === nothing
@@ -191,7 +184,7 @@ function workspace_didChangeWorkspaceFolders_notification(params::DidChangeWorks
         load_folder(wksp, server, added_docs)
 
 
-        files = JuliaWorkspaces.read_path_into_textdocuments(wksp.uri)
+        files = JuliaWorkspaces.read_path_into_textdocuments(wksp.uri, ignore_io_errors=true)
 
         for i in files
             # This might be a sub folder of a folder that is already watched