Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce requirements list in setup.cfg #252

Closed
kwinkunks opened this issue May 23, 2023 · 2 comments
Closed

Reduce requirements list in setup.cfg #252

kwinkunks opened this issue May 23, 2023 · 2 comments
Assignees
Labels
dependencies Pull requests that update a dependency file

Comments

@kwinkunks
Copy link

Thanks for continuing to support classic notebooks, and improving the architecture 🙌

Currently the install_requires list is comprehensive:

https://github.com/jupyter/nbclassic/blob/v1.0.0/setup.cfg#L30-L49

But most of these requirements are requirements of jupyter-server, and that is a requirement of notebook-shim so the list could be substantially reduced to:

install_requires:
    ipykernel
    ipython-genutils
    nest-asyncio
    notebook-shim

Personally I think this makes it easier for people to figure out their dependency requirements, but I realize the team may have another viewpoint.

@echarles
Copy link
Member

I agree with you @kwinkunks By any chance, would you have appetite to open a PR for this. I would be very happy to review and help you with that.

@RRosio RRosio added the dependencies Pull requests that update a dependency file label Aug 1, 2023
@RRosio RRosio self-assigned this Aug 4, 2023
@RRosio
Copy link
Collaborator

RRosio commented Aug 11, 2023

#259 has been merged! The changes should be reflected in the next release of NbClassic. I'll go ahead and close this issue. Thanks again!

@RRosio RRosio closed this as completed Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

3 participants