Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot open directory because it is a submodule' #93

Open
WetHat opened this issue Sep 30, 2019 · 2 comments
Open

Cannot open directory because it is a submodule' #93

WetHat opened this issue Sep 30, 2019 · 2 comments

Comments

@WetHat
Copy link

WetHat commented Sep 30, 2019

Hi,

I'm having an issue with Git submodules as described below:

Description

When a directory is a GIT submodule, an attempt to open it with the @jupyterlab/github extension
displays an error:

Annotation 2019-09-30 232058

Reproduce

  1. Create a GIT submodule on the file system typing something like this on the
    command line
# To add and clone a new submodule
$ git submodule add https://github.com/chaconinc/DbConnector
$ git clone https://github.com/chaconinc/MainProject
$ git submodule init
$ git submodule update
  1. Open Jupyter Lab with the @jupyterlab/github extension installed.
  2. Open the GIT panels and browse to the submodule
  3. See error 'Cannot open <directory> because it is a submodule'

Expected behavior

Git submodules should be supported like regular Git modules. That would be extremely helpful!

Context

  • Python package version:

    # packages in environment at c:\Miniconda:
    #
    # Name                Version               Build  Channel
    jupyterlab-github    1.0.0                 pypi_0    pypi
    

Thanks,

WetHat

@ian-r-rose
Copy link
Member

Hi @WetHat, unfortunately this is expected behavior. We don't have a way currently to recursively go into a submodule (indeed, it may not even be on GitHub).

If somebody wanted to try implementing that, it could be an interesting exercise, but I don't know how feasible it is.

@ian-r-rose
Copy link
Member

(also, sorry for the extremely slow response)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants