Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

template_dir or templates_dir? #462

Open
krassowski opened this issue Feb 10, 2025 · 1 comment · May be fixed by #463
Open

template_dir or templates_dir? #462

krassowski opened this issue Feb 10, 2025 · 1 comment · May be fixed by #463
Labels
bug

Comments

@krassowski
Copy link
Member

jupyterlab_server/jupyterlab_server/config.py

Lines 252 to 254 in bca8978

labextensions_url = Unicode("", help="The url for federated JupyterLab extensions").tag(
config=True
)

matches

jupyterlab_server/jupyterlab_server/config.py

Lines 321 to 323 in bca8978

@default("labextensions_url")
def _default_labextensions_url(self) -> str:
return ujoin(self.app_url, "extensions/")

but

jupyterlab_server/jupyterlab_server/config.py

Line 241 in bca8978

templates_dir = Unicode("", help="The application templates directory.").tag(config=True)

does not

jupyterlab_server/jupyterlab_server/config.py

Lines 317 to 319 in bca8978

@default("template_dir")
def _default_template_dir(self) -> str:
return DEFAULT_TEMPLATE_PATH

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
1 participant
@krassowski