fix(homebrew): refuse placeholder versions#367
Conversation
There was a problem hiding this comment.
💡 Codex Review
code/code-rs/core/src/rollout/list.rs
Lines 272 to 276 in 10da427
The new listing logic orders sessions by file mtime (candidates.sort_by_key(|(modified, …)| Reverse(*modified))), but the pagination cursor is still built solely from the filename’s timestamp and UUID. When a user touches an older session so that its mtime becomes newer than a later session, the first page now shows that touched file, yet the next_cursor encodes only its original timestamp. On the subsequent call the anchor comparison (ts < anchor_ts || (ts == anchor_ts && sid < anchor_id)) will skip any files whose timestamps are newer than the cursor but whose mtimes are older, causing them to disappear from pagination entirely. The cursor needs to incorporate the mtime component (or the anchor comparison must mirror the new ordering) to avoid missing or duplicated sessions whenever mtimes diverge from path timestamps.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Preview Build rerun triggered after #364 merged; watching for green checks. |
|
Fresh Preview Build queued with updated toolchain after #364 merged; watching for green checks. |
|
Preview Build rerun queued with Rust 1.90.0 plus MUSL targets after #370 merged. Tracking run: https://github.com/just-every/code/actions/runs/18870475162 |
1 similar comment
|
Preview Build rerun queued with Rust 1.90.0 plus MUSL targets after #370 merged. Tracking run: https://github.com/just-every/code/actions/runs/18870475162 |
804b5ad to
b7927a2
Compare
Summary
Testing
Fixes #328