Skip to content

fix(homebrew): refuse placeholder versions#367

Merged
zemaj merged 4 commits intomainfrom
fix/homebrew-formula-version-guard
Oct 29, 2025
Merged

fix(homebrew): refuse placeholder versions#367
zemaj merged 4 commits intomainfrom
fix/homebrew-formula-version-guard

Conversation

@zemaj
Copy link

@zemaj zemaj commented Oct 28, 2025

Summary

  • treat 0.0.0 / 0.0.0-dev as unset when generating the Homebrew formula
  • prefer explicit CLI argument, then workspace Cargo.toml, then package.json, then latest git tag
  • hard-fail with a clear error if no real version is found to avoid publishing broken formulas

Testing

  • (script change only)

Fixes #328

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

fn build_next_cursor(items: &[ConversationItem]) -> Option<Cursor> {
let last = items.last()?;
let file_name = last.path.file_name()?.to_string_lossy();
let (ts, id) = parse_timestamp_uuid_from_filename(&file_name)?;
Some(Cursor::new(ts, id))

P1 Badge Pagination cursor ignores modification-time ordering

The new listing logic orders sessions by file mtime (candidates.sort_by_key(|(modified, …)| Reverse(*modified))), but the pagination cursor is still built solely from the filename’s timestamp and UUID. When a user touches an older session so that its mtime becomes newer than a later session, the first page now shows that touched file, yet the next_cursor encodes only its original timestamp. On the subsequent call the anchor comparison (ts < anchor_ts || (ts == anchor_ts && sid < anchor_id)) will skip any files whose timestamps are newer than the cursor but whose mtimes are older, causing them to disappear from pagination entirely. The cursor needs to incorporate the mtime component (or the anchor comparison must mirror the new ordering) to avoid missing or duplicated sessions whenever mtimes diverge from path timestamps.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@zemaj
Copy link
Author

zemaj commented Oct 28, 2025

Preview Build rerun triggered after #364 merged; watching for green checks.

@zemaj
Copy link
Author

zemaj commented Oct 28, 2025

Fresh Preview Build queued with updated toolchain after #364 merged; watching for green checks.

@zemaj
Copy link
Author

zemaj commented Oct 28, 2025

Preview Build rerun queued with Rust 1.90.0 plus MUSL targets after #370 merged. Tracking run: https://github.com/just-every/code/actions/runs/18870475162

1 similar comment
@zemaj
Copy link
Author

zemaj commented Oct 28, 2025

Preview Build rerun queued with Rust 1.90.0 plus MUSL targets after #370 merged. Tracking run: https://github.com/just-every/code/actions/runs/18870475162

@zemaj zemaj force-pushed the main branch 2 times, most recently from 804b5ad to b7927a2 Compare October 28, 2025 23:57
@zemaj zemaj merged commit 16f04bc into main Oct 29, 2025
8 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

homebrew tap is broken (regression)

1 participant

Comments