Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overlap-max value is not functioning as expected #22

Open
MoeFwacky opened this issue Aug 6, 2017 · 1 comment
Open

overlap-max value is not functioning as expected #22

MoeFwacky opened this issue Aug 6, 2017 · 1 comment
Milestone

Comments

@MoeFwacky
Copy link
Collaborator

This is my Saturday evening schedule

        <time title="random" type="movie" strict-time="true" time-shift="15" overlap-max="60">19:30</time>
        <time title="Seinfeld" type="series" strict-time="false" time-shift="15" overlap-max="20">21:00</time>
        <time title="King of the Hill" type="series" strict-time="false" time-shift="15" overlap-max="20">21:30</time>
        <time title="The Simpsons" type="series" strict-time="false" time-shift="15" overlap-max="20">22:00</time>
        <time title="Futurama" type="series" strict-time="true" time-shift="15" overlap-max="20">22:30</time>
        <time title="Quantum Leap" type="series" strict-time="true" time-shift="15" overlap-max="30">23:00</time>

This is set up to allow for Seinfeld, King of the Hill and the Simpsons to follow a movie that isn't long enough to fill three hours. The intended behavior is to allow each of those shows to get bumped back 15 minutes once, then cancelled if the movie runs over.

What happened though is that the shows didn't get cancelled and were pushed back into the strict time part of the schedule (I removed commercials for readability)

222 Movies A.I. Artificial Intelligence 07:30:00 PM
228 TV Shows Seinfeld The Pick 10:00:00 PM
231 TV Shows King of the Hill Wings of the Dope 10:30:00 PM
234 TV Shows The Simpsons Treehouse of Horror XV 11:00:00 PM
235 TV Shows Futurama 31st Century Fox 10:30:00 PM
241 TV Shows Quantum Leap Another Mother 11:00:00 PM

The script started playback for the duplicate time entries in order, so at 11 the Simpsons started briefly then Quantum Leap fired off and continued to play.

I was using the develop branch version committed at 14:32 PDT (UTC-7) Aug 6 2017.

@MoeFwacky MoeFwacky added the bug label Aug 6, 2017
@justinemter
Copy link
Owner

I actually haven't messed with overlap-max at all. I just added the field in the xml and kind of forgot about it. I'm going to add that in but first want to tackle any big bugs that pop up in the app as-is. I've gotten a little weirdness in my schedule this morning and hope to figure that out, other than that it seems to be running ok. I'll look into all of this when home.

@justinemter justinemter added this to the beta milestone Sep 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants