Skip to content

CONTRIBUTING.md

Latest commit

 

History

History
46 lines (34 loc) · 2.11 KB

CONTRIBUTING.md

File metadata and controls

46 lines (34 loc) · 2.11 KB

Contributing to Penlight

So you want to contribute to Penlight? Fantastic! Here's a brief overview on how best to do so.

What to change

Here's some examples of things you might want to make a pull request for:

  • New features
  • Bugfixes
  • Inefficient blocks of code

If you have a more deeply-rooted problem with how the library is built or some of the stylistic decisions made in the code, it's best to create an issue before putting the effort into a pull request. The same goes for new features - it might be best to check the project's direction, existing pull requests, and currently open and closed issues first.

Using Git appropriately

Penlight uses two main branches;

  1. stable which is the current released version. This version only accepts bugfixes and backward compatible changes/additions.
  2. master is the next major version, with new features and probably incompatibilities. Fixes and changes from stable will regularly be merged in master as well.

Here's how to go about contributing to Penlight

  1. Fork the repository to your Github account.
  2. Create a topical branch - a branch whose name is succint but explains what you're doing, such as "added-klingon-cloacking-device" - either from master or stable depending on what your changing.
  3. Make your changes, committing at logical breaks.
  4. Push your branch to your personal account
  5. Create a pull request
  6. Watch for comments or acceptance

If you wanna be a rockstar;

  1. update the CHANGES.md file
  2. add tests that show the defect your fix repairs, or that tests your new feature

Please note - if you want to change multiple things that don't depend on each other, make sure you check the master/stable branch back out before making more changes - that way we can take in each change separately. And against the correct branch.