Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommendations feature does not persist after player is closed #122

Open
hunyoboy opened this issue Feb 5, 2025 · 2 comments
Open

Recommendations feature does not persist after player is closed #122

hunyoboy opened this issue Feb 5, 2025 · 2 comments
Labels
bug Something isn't working Groomed JWP team has reviewed the ticket and deemed it necessary native-sdk-issue Work is blocked by native SDK

Comments

@hunyoboy
Copy link
Contributor

hunyoboy commented Feb 5, 2025

Describe the bug
Noticed an android-only issue that recommendations is only enabled the first time the player is opened. Once player is closed and reopened, recommendations is interestingly disabled. In fact, even if you open another player configured to display recommendations, no recommendations on any players will show up anymore. It'll only be enabled again if you close and reopen the whole app.

To Reproduce
Use the Example application as reference material and a starting place to reproduce any bugs.

Steps to reproduce the behavior:

  1. Download the rn jwplayer source code here - https://github.com/jwplayer/jwplayer-react-native
  2. Replace the content of the Example app file with this gist's content - https://gist.github.com/hunyoboy/fede5a73c9c498e0d3d6f844eb16439a. Ensure to also replace with real values here - https://gist.github.com/hunyoboy/fede5a73c9c498e0d3d6f844eb16439a#file-singleexample-js-L23
  3. Run the Example app. Make sure to reference the latest version. v1.0.3 at the time of this ticket creation.
  4. Once the app is up and running, go to Single Example section and observe the bug.
  5. Reference the video below.

Expected behavior

  1. Recommendations should be enabled if player is configured for it.
  2. Player configured for recommendations should remain recommendations-enabled even if it's closed and reopened.

Screenshots / Visual evidence

recommendation-bug.mp4

Desktop (please complete the following information):
No build issue.

Additional context
We use Jwplayer recommendations heavily on both ios/android.

JWP Ticketing
https://support.jwplayer.com/hc/en-us/requests/226877

ℹ️ While Issues are valuable for open-source collaboration, a JWP request ensures that you will receive clear timelines and efficient support.
@hunyoboy hunyoboy added the needs-grooming Has not been reviewed by codeowners for scope/validation label Feb 5, 2025
@Jmilham21
Copy link
Collaborator

This is a weird one, taking a look @hunyoboy.

@Jmilham21
Copy link
Collaborator

I have determined this to be an issue on the native SDK side. I will make an internal ticket and bring the patch over as soon as I can release a version with the fix.

@Jmilham21 Jmilham21 added bug Something isn't working Groomed JWP team has reviewed the ticket and deemed it necessary native-sdk-issue Work is blocked by native SDK and removed needs-grooming Has not been reviewed by codeowners for scope/validation labels Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Groomed JWP team has reviewed the ticket and deemed it necessary native-sdk-issue Work is blocked by native SDK
Projects
None yet
Development

No branches or pull requests

2 participants