Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] [Android] Duplicate Fullscreen Icons #123

Open
jakubjuraszek opened this issue Feb 6, 2025 · 2 comments
Open

[BUG] [Android] Duplicate Fullscreen Icons #123

jakubjuraszek opened this issue Feb 6, 2025 · 2 comments
Labels
needs-grooming Has not been reviewed by codeowners for scope/validation

Comments

@jakubjuraszek
Copy link

Describe the bug
On Android, while loading a video in JWPlayer, two fullscreen icons are displayed in the player instead of one. This issue occurs during the video initialization phase and persists until the video starts playing.

To Reproduce
Use the Example application as a reference material and follow these steps:

Open the application on an Android device.

  1. Load a video using JWPlayer.
  2. If not focused, focus the player
  3. Observe the player interface before playback starts.
  4. Notice that two fullscreen icons appear instead of one.

Steps to reproduce the behavior:

  1. Provide thorough
  2. And complete
  3. Steps for reproduction
  4. That are reliably reproducible

Expected behavior
Only a single fullscreen icon should be displayed in the JWPlayer UI during video loading.

Screenshots / Visual evidence
Image

Desktop (please complete the following information):
If you are having a build issue, we would like to know about your machine.

  • Result of npx react-native info

Device(s) affected
Any Android device or emulator

@jakubjuraszek jakubjuraszek added the needs-grooming Has not been reviewed by codeowners for scope/validation label Feb 6, 2025
@Jmilham21
Copy link
Collaborator

What version of the JWP Android SDK are you using? Did you see this behavior in the Example app of this library? I believe this was patched natively a few versions ago.

@jakubjuraszek
Copy link
Author

jakubjuraszek commented Feb 12, 2025

@Jmilham21 The issue occurs in the Example app as well. I'm using the latest available version according to https://www.npmjs.com/package/@jwplayer/jwplayer-react-native, which is 1.0.3, com.jwplayer:jwplayer-core:4.18.4, along with React Native 0.73.8.

Could you provide a commit which fix that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-grooming Has not been reviewed by codeowners for scope/validation
Projects
None yet
Development

No branches or pull requests

2 participants