Fixed addEventListener() not allowing built-in functions as listeners

Author: agronholm

CHANGES.rst

@@ -1,3 +1,9 @@
+v2.1.1
+======
+
+* Fixed addEventListener() not allowing built-in functions as event listeners
+
+
 v2.1.0
 ======
 

RELEASE

@@ -1 +1 @@
-2.1.0
+2.1.1

swingutils/events.py

@@ -1,6 +1,4 @@
 from __future__ import unicode_literals
-from inspect import getargspec
-from types import MethodType
 
 from java.util import EventListener
 
@@ -84,12 +82,6 @@ class so that autodetection will work)
              events (with :meth:`~EventListenerWrapper.unlisten`)
 
     """
-    # Sanity check
-    argspec = getargspec(listener)
-    min_args = 2 if isinstance(listener, MethodType) else 1
-    if len(argspec.args) < min_args and not argspec.varargs:
-        raise TypeError('The target callable has too few parameters declared')
-
     addMethodName = 'add%s' % eventInterface.__name__
     addMethod = getattr(target, addMethodName)
     removeMethodName = 'remove%s' % eventInterface.__name__

tests/test_events.py

@@ -49,3 +49,17 @@ def selectionListener(event, **kwargs):
 
     lst.setSelectionInterval(0, 0)
     assert holder[0] == {'test': 2}
+
+
+def testBuiltinListener():
+    model = DefaultListModel()
+    lst = JList(model)
+    model.addElement(u'Test')
+    events = []
+    addEventListener(lst, ListSelectionListener, 'valueChanged',
+                     events.append)
+
+    lst.setSelectionInterval(0, 0)
+    assert len(events) == 1
+    assert events[0].firstIndex == 0
+    assert events[0].lastIndex == 0