From a8ae50ae2672a1933960b7f1783033b2107ad738 Mon Sep 17 00:00:00 2001 From: Kosh Date: Tue, 4 Apr 2017 16:59:03 +0800 Subject: [PATCH] reading for 1.7.0 --- app/build.gradle | 4 ++-- app/src/main/java/com/fastaccess/ui/base/BaseActivity.java | 2 ++ .../modules/repos/extras/labels/create/CreateLableView.java | 1 + .../repos/extras/milestone/create/CreateMilestoneView.java | 1 + app/src/main/res/values/strings.xml | 1 + 5 files changed, 7 insertions(+), 2 deletions(-) diff --git a/app/build.gradle b/app/build.gradle index b1c297634..79b48057b 100644 --- a/app/build.gradle +++ b/app/build.gradle @@ -26,8 +26,8 @@ android { applicationId "com.fastaccess.github" minSdkVersion 21 targetSdkVersion 25 - versionCode 160 - versionName "1.6.0" + versionCode 170 + versionName "1.7.0" signingConfig signingConfigs.signing buildConfigString "GITHUB_CLIENT_ID", (buildProperties.secrets['github_client_id'] | buildProperties.notThere['github_client_id']).string buildConfigString "GITHUB_SECRET", (buildProperties.secrets['github_secret'] | buildProperties.notThere['github_secret']).string diff --git a/app/src/main/java/com/fastaccess/ui/base/BaseActivity.java b/app/src/main/java/com/fastaccess/ui/base/BaseActivity.java index ee11179bb..219014795 100644 --- a/app/src/main/java/com/fastaccess/ui/base/BaseActivity.java +++ b/app/src/main/java/com/fastaccess/ui/base/BaseActivity.java @@ -384,6 +384,8 @@ private void setupOrg(@NonNull View view) { dropDownIcon.setTag(null); dropDownIcon.setRotation(0.0F); } + } else { + showErrorMessage(getString(R.string.no_orgs)); } }); } diff --git a/app/src/main/java/com/fastaccess/ui/modules/repos/extras/labels/create/CreateLableView.java b/app/src/main/java/com/fastaccess/ui/modules/repos/extras/labels/create/CreateLableView.java index d3eb52296..b1bba5f93 100644 --- a/app/src/main/java/com/fastaccess/ui/modules/repos/extras/labels/create/CreateLableView.java +++ b/app/src/main/java/com/fastaccess/ui/modules/repos/extras/labels/create/CreateLableView.java @@ -83,6 +83,7 @@ public static CreateLableView newInstance(@NonNull String login, @NonNull String toolbar.setNavigationIcon(R.drawable.ic_clear); toolbar.setNavigationOnClickListener(item -> dismiss()); toolbar.inflateMenu(R.menu.add_menu); + toolbar.getMenu().findItem(R.id.add).setIcon(R.drawable.ic_send); toolbar.setOnMenuItemClickListener(item -> { boolean emptyColor = InputHelper.isEmpty(description); boolean emptyName = InputHelper.isEmpty(name); diff --git a/app/src/main/java/com/fastaccess/ui/modules/repos/extras/milestone/create/CreateMilestoneView.java b/app/src/main/java/com/fastaccess/ui/modules/repos/extras/milestone/create/CreateMilestoneView.java index 91072e7da..c951bf589 100644 --- a/app/src/main/java/com/fastaccess/ui/modules/repos/extras/milestone/create/CreateMilestoneView.java +++ b/app/src/main/java/com/fastaccess/ui/modules/repos/extras/milestone/create/CreateMilestoneView.java @@ -76,6 +76,7 @@ public static CreateMilestoneView newInstance(@NonNull String login, @NonNull St toolbar.setNavigationIcon(R.drawable.ic_clear); toolbar.setNavigationOnClickListener(item -> dismiss()); toolbar.inflateMenu(R.menu.add_menu); + toolbar.getMenu().findItem(R.id.add).setIcon(R.drawable.ic_send); toolbar.setOnMenuItemClickListener(item -> { getPresenter().onSubmit(InputHelper.toString(title), InputHelper.toString(dueOnEditText), InputHelper.toString(description), login, repo); return true; diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index 0210cd21b..9e39f3546 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -336,4 +336,5 @@ Members No members No teams + No Organizations \ No newline at end of file