fix: Make sure we uri encode credentials and db name (#7)

hofmeister · web-flow · commit f4a367a45743 · 2023-06-29T14:31:02.000+02:00
diff --git a/src/cmd-database-url.ts b/src/cmd-database-url.ts
@@ -16,14 +16,14 @@ async function resolveUrl(resourceName: string) {
 
     let credentials = ''
     if (dbInfo.credentials?.username) {
-        credentials += dbInfo.credentials.username;
+        credentials += encodeURIComponent(dbInfo.credentials.username);
 
         if (dbInfo.credentials.password) {
-            credentials += ':' + dbInfo.credentials.password;
+            credentials += ':' + encodeURIComponent(dbInfo.credentials.password);
         }
     }
 
-    return `mongodb://${credentials}@${dbInfo.host}:${dbInfo.port}/${dbName}?authSource=admin&directConnection=true`;
+    return `mongodb://${credentials}@${dbInfo.host}:${dbInfo.port}/${encodeURIComponent(dbName)}?authSource=admin&directConnection=true`;
 }
 
 if (!process.argv[2]) {

Original file line number	Diff line number	Diff line change
`@@ -16,14 +16,14 @@ async function resolveUrl(resourceName: string) {`
`16`	`16`
`17`	`17`	`let credentials = ''`
`18`	`18`	`if (dbInfo.credentials?.username) {`
`19`		`- credentials += dbInfo.credentials.username;`
	`19`	`+ credentials += encodeURIComponent(dbInfo.credentials.username);`
`20`	`20`
`21`	`21`	`if (dbInfo.credentials.password) {`
`22`		`- credentials += ':' + dbInfo.credentials.password;`
	`22`	`+ credentials += ':' + encodeURIComponent(dbInfo.credentials.password);`
`23`	`23`	`}`
`24`	`24`	`}`
`25`	`25`
`26`		- return `mongodb://${credentials}@${dbInfo.host}:${dbInfo.port}/${dbName}?authSource=admin&directConnection=true`;
	`26`	+ return `mongodb://${credentials}@${dbInfo.host}:${dbInfo.port}/${encodeURIComponent(dbName)}?authSource=admin&directConnection=true`;
`27`	`27`	`}`
`28`	`28`
`29`	`29`	`if (!process.argv[2]) {`