Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide on Queue Mechanism #166

Open
stephenmichaelf opened this issue May 20, 2017 · 1 comment
Open

Decide on Queue Mechanism #166

stephenmichaelf opened this issue May 20, 2017 · 1 comment
Milestone

Comments

@stephenmichaelf
Copy link
Collaborator

Azure Service Bus?

Some discussion has happened in Gitter on requirements for this:

  • I like the idea of queues alot, but they can bring some design decisions that need making upfront for performance issues (Because lets face it Github produces alot of Notifications lol). How long do we keep the messages? Do we requeue and circle them? If they are stale (i.e. haven't been read for X long) do we Store them if no processed. How do we register interest in a message so that if NotificationDbWriter picks it up, we make sure the message is still available to be processed by other Services?
  • I would suggest to use repo-policy for retirement. Default 6 months / 1 year.
  • I like that idea but I would wait for other messages that are close to reach that X mins/hours so that we don't fill that service with requests. Imagine thousends of queued notifications by 1 min time gap are queued and then each of them starts passing that time limit one bye one and we start sending requests per message. I would send them by chunks -- maybe not all of them as then the first one that was supposed to get out of the queue would be there for a thousand minutes waiting for the next. Maybe a time range more than a time gap would be nice to expire them.
@stephenmichaelf stephenmichaelf added this to the 2.0 milestone May 20, 2017
@karelz
Copy link
Owner

karelz commented May 20, 2017

@stephenmichaelf not sure why you assigned the design decisions to me ... I would rather have a discussion on the topic and then we can decide together.
I don't have specific expertise in the space, beyond general componentisation design approach ;)

@karelz karelz removed their assignment May 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants