This repository was archived by the owner on Dec 28, 2018. It is now read-only.

Enable ESLint's 'no-magic-numbers' rule #428

Open

tetsuharuohzeki opened this issue Oct 22, 2015 · 1 comment

Labels

A-testing/lint I-enhancement

Contributor

tetsuharuohzeki commented Oct 22, 2015

http://eslint.org/docs/rules/no-magic-numbers
A modern JIT compiler would make inlining a constant variable. We don't have to worriy about perf regression.

tetsuharuohzeki added I-enhancement A-client A-infrastructure labels

tetsuharuohzeki added A-testing/lint and removed A-client A-infrastructure labels

Contributor Author

tetsuharuohzeki commented Jun 11, 2016

This is important rules for the team which many beginner programmer are in.
However, in almost case, a sane programmer knows why we hate a magic number.
- And this rules is too strictly for testing codes.

So we would exclude this rules for testing codes even if we'll enable this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.