Skip to content

Commit 0c6923e

Browse files
committed
Re-add a note about sarcasm to the Code Review guide
[ci skip]
1 parent c7ec592 commit 0c6923e

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

doc/development/code_review.md

+3
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,9 @@ request is up to one of our merge request "endbosses", denoted on the
2525
- Be explicit. Remember people don't always understand your intentions online.
2626
- Be humble. ("I'm not sure - let's look it up.")
2727
- Don't use hyperbole. ("always", "never", "endlessly", "nothing")
28+
- Be careful about the use of sarcasm. Everything we do is public; what seems
29+
like good-natured ribbing to you and a long-time colleague might come off as
30+
mean and unwelcoming to a person new to the project.
2831
- Consider one-on-one chats or video calls if there are too many "I didn't
2932
understand" or "Alternative solution:" comments. Post a follow-up comment
3033
summarizing one-on-one discussion.

0 commit comments

Comments
 (0)