Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue parsing on parse error and collect all parse errors #68

Closed
zkat opened this issue Dec 9, 2023 · 0 comments · Fixed by #70
Closed

Continue parsing on parse error and collect all parse errors #68

zkat opened this issue Dec 9, 2023 · 0 comments · Fixed by #70
Labels
breaking semver-major change enhancement New feature or request

Comments

@zkat
Copy link
Member

zkat commented Dec 9, 2023

Modern parsers don't just stop at the first error they find--they continue optimistically as best they can, either collecting or printing errors as they go.

kdl-rs should do this, too, by returning a wrapper around a collection of parse errors instead of a single error.

This issue can dovetail with #67, since we're going to be kinda rewriting the parser anyway.

@zkat zkat added enhancement New feature or request breaking semver-major change labels Dec 9, 2023
@zkat zkat linked a pull request Apr 4, 2024 that will close this issue
@zkat zkat closed this as completed in #70 Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking semver-major change enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant