Test require distinction between floats and integers #300
Patitotective
started this conversation in
General
Replies: 1 comment
-
it's expected that implementations will need to massage their test executions to match the tests. The tests are meant to be general guidelines, and if your parser has particular quirks, you can definitely compensate for that in your own test suite. I think this is a good example of that. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Quoting the spec:
The spec says that there is no distinction between integer and float numbers, though some tests like
numeric_prop.kdl
andpositive_int.kdl
need your KDL implementation to distinguish between both floats and integers in order to match the expected_kdl.numeric_prop.kdl
:node prop=10.0
node prop=10.0
positive_int.kdl
:node +10
node 10
(As you can see an integer as input expects an integer as output, same with float, this makes your implementation to difference integers and floats).
I suggest making all tests expect floating numbers.
Beta Was this translation helpful? Give feedback.
All reactions