Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2]: Case sensitivity for keywords? #380

Closed
zkat opened this issue Feb 16, 2024 · 4 comments
Closed

[v2]: Case sensitivity for keywords? #380

zkat opened this issue Feb 16, 2024 · 4 comments
Labels
breaking This can only be done for the next major version of KDL enhancement New feature or request

Comments

@zkat
Copy link
Member

zkat commented Feb 16, 2024

Can/should we make keywords case insensitive? That is, #true, #null, #nan, etc.

@zkat zkat added enhancement New feature or request breaking This can only be done for the next major version of KDL labels Feb 16, 2024
@tabatkins
Copy link
Contributor

I think I'm 100% neutral on this. Like, CSS is case-insensitive with its keywords, but also anyone who writes COLOR: Red; deserves jail.

But I also suspect I'll naturally try to spell it #NaN, and sometimes people like #TRUE to make them stand out more, so eh.

@larsgw
Copy link
Contributor

larsgw commented Feb 19, 2024

I feel like these alternatives are mainly just things that people are going to want to write linter rules against. But I had the same feeling about quote-less strings, and maybe alternatives are fine.

@tabatkins
Copy link
Contributor

Similar to the "I'll probably type #NaN" thing, depending on whether I've been most recently writing Python or JS my fingers naturally spell it True or true.

So I guess I'm weakly for making them insensitive (but maybe with a recommendation about using lowercase as the canonical serialization?)

@zkat
Copy link
Member Author

zkat commented Oct 3, 2024

Closing this: just keep them lowercase

@zkat zkat closed this as not planned Won't fix, can't repro, duplicate, stale Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking This can only be done for the next major version of KDL enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants