Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taproot #293

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

Jeanmichel7
Copy link
Contributor

@Jeanmichel7 Jeanmichel7 commented Jan 26, 2025

test_p2wpkh_22inputs() (gas usage est.: 3192030989) -> (gas usage est.: 2146289982)

…e in validation + add test p2wpkh witness + handle error in loop multi inputs
Copy link

vercel bot commented Jan 26, 2025

@Jeanmichel7 is attempting to deploy a commit to the keep-starknet-strange Team on Vercel.

A member of the Team first needs to authorize it.

@Jeanmichel7 Jeanmichel7 marked this pull request as ready for review January 26, 2025 01:06
@Jeanmichel7
Copy link
Contributor Author

@lana-shanghai

@Jeanmichel7
Copy link
Contributor Author

@b-j-roberts @lana-shanghai
Can you check the PR?
I couldn't manage the middle hash cache in the same way as on btcd, a dict is useless because we execute transaction by transaction, we'd have to go back and forth between raito and shini to optimize.
So I store the hashes for the entire transaction and send a copy to the engine.
And to be compatible with all the tests already in place, I've opted to initialize the cache when it's created from the tx if it's needed.

I've got another PR for the merkle root coming up.

@Jeanmichel7 Jeanmichel7 changed the title hashcache Taproot Feb 3, 2025
@Jeanmichel7
Copy link
Contributor Author

@b-j-roberts
ok i've gone as far as i can alone, now it's up to you
if the impl of hashcahe is appropriate,
if we use digest trait,
etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] Implement taproot root_hash function [feat] Implement P2TR
1 participant