You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Feb 6, 2025. It is now read-only.
We currently also allow "nan" and "inf" as input values for GraphQLFloat and GraphQLDecimal in deserialize_json_argument and in validate_argument_types. However, we don't have a single integration test where with float("nan") or Decimal("inf") arguments.
So we don't really know if we are returning a "standard python representation that can be used in queries" in deserialize_json_argument or if the validation in validate_argument_types "is stricter than the validation done by any specific backend"
So I think that we should either add integration tests proving that these values can be used in database queries or disallow them.
The text was updated successfully, but these errors were encountered:
For MSSQL, filtering on float("nan") or float("inf") leads to a sqlalchemy ProgrammingError with SQL Server. Filtering on Decimal("nan") or Decimal("inf") doesn't lead to any errors, but filtering on less than < Decimal("inf") lead to no results on the test query.
For OrientDB, it didn't lead to any errors, but filtering on < Decimal("inf") didn't lead to any results either.
For neo4j, filtering on < float("inf") worked. Neo4j doesn't support decimal types.
We don't have numeric tests for redisgraph so I wasn't able to test this.
Disclaimer: I am not sure how to insert "nan" or "inf" values into the target databases and didn't bother to try figuring it out.
We currently also allow "nan" and "inf" as input values for
GraphQLFloat
andGraphQLDecimal
indeserialize_json_argument
and invalidate_argument_types
. However, we don't have a single integration test where withfloat("nan")
orDecimal("inf")
arguments.So we don't really know if we are returning a "standard python representation that can be used in queries" in
deserialize_json_argument
or if the validation invalidate_argument_types
"is stricter than the validation done by any specific backend"So I think that we should either add integration tests proving that these values can be used in database queries or disallow them.
The text was updated successfully, but these errors were encountered: