Skip to content

Improve move_zeros algorithm (readability and efficiency) #2702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improve move_zeros algorithm (readability and efficiency) #2702

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions algorithms/arrays/move_zeros.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,20 +7,20 @@
The time complexity of the below algorithm is O(n).
"""


# False == 0 is True
def move_zeros(array):
result = []
zeros = 0

for i in array:
if i == 0 and type(i) != bool: # not using `not i` to avoid `False`, `[]`, etc.
# Check for numeric zeros but exclude boolean False
# False and other falsy values (like [], '') are NOT treated as zeros.
if i == 0 and not isinstance(i, bool):
zeros += 1
else:
result.append(i)

# Append zeros to the end without allocating another temporary list
for _ in range(zeros):
result.append(0)

result.extend([0] * zeros)
return result


print(move_zeros([False, 1, 0, 1, 2, 0, 1, 3, "a"]))