From 46b8fbbb85cf96012a98110e6428c448d7d2d54b Mon Sep 17 00:00:00 2001 From: Kevin Moore Date: Sat, 3 Oct 2026 20:54:37 +0000 Subject: [PATCH] Declare path dep in path_package/negative fixture - `path_package/negative/lib/idiomatic.dart` imports `package:path`; the fixture pubspec now says so (`path: ^1.9.0`). - Drop the `depend_on_referenced_packages` exemption from `test/fixtures/analysis_options.yaml` added in #57 to paper over this. - `PathPackageRule` never reads fixture pubspecs, so rule behavior is unchanged. --- packages/dash_discover/test/fixtures/analysis_options.yaml | 4 ---- .../test/fixtures/path_package/negative/pubspec.yaml | 3 +++ 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/packages/dash_discover/test/fixtures/analysis_options.yaml b/packages/dash_discover/test/fixtures/analysis_options.yaml index c41dcf2..57e985f 100644 --- a/packages/dash_discover/test/fixtures/analysis_options.yaml +++ b/packages/dash_discover/test/fixtures/analysis_options.yaml @@ -3,9 +3,6 @@ # the fixtures intentionally violate so their semantics stay untouched: # - lines_longer_than_80_chars: inline "Suboptimal:/Skill abstention" notes # are part of the fixture narrative. -# - depend_on_referenced_packages: `path_package/negative` imports -# `package:path` without a fixture pubspec dep (resolved via the host -# package). # - avoid_relative_lib_imports / unreachable_from_main: # `sealed_hierarchy/negatives/test` models a subtype declared outside # `lib/` via a relative import so the rule must abstain from sealing. @@ -14,6 +11,5 @@ include: ../../../../analysis_options.yaml linter: rules: avoid_relative_lib_imports: false - depend_on_referenced_packages: false lines_longer_than_80_chars: false unreachable_from_main: false diff --git a/packages/dash_discover/test/fixtures/path_package/negative/pubspec.yaml b/packages/dash_discover/test/fixtures/path_package/negative/pubspec.yaml index 7c2919f..eb4e235 100644 --- a/packages/dash_discover/test/fixtures/path_package/negative/pubspec.yaml +++ b/packages/dash_discover/test/fixtures/path_package/negative/pubspec.yaml @@ -4,3 +4,6 @@ publish_to: none environment: sdk: ^3.9.0 + +dependencies: + path: ^1.9.0