Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keycloak.js does not validate Issuer Identifier #13

Open
2 tasks done
vickeybrown opened this issue Sep 29, 2023 · 1 comment
Open
2 tasks done

keycloak.js does not validate Issuer Identifier #13

vickeybrown opened this issue Sep 29, 2023 · 1 comment
Assignees

Comments

@vickeybrown
Copy link

Before reporting an issue

Area

adapter/javascript

Describe the bug

keycloak/keycloak#20621 added support for RFC 9207, which requires clients validate that the Issuer Identifier returned from the Authorization Code Flow response is what is expected before proceeding with the authorization grant. However, there was no logic added in Keycloak.js to do this check.

Version

main

Expected behavior

Keycloak.js validates that the "iss" parameter from the Authorization Code Flow response matches the issuer identifier of the authorization server where the authorization request was sent to, as described in https://datatracker.ietf.org/doc/html/rfc9207#name-validating-the-issuer-ident

Actual behavior

Keycloak.js does nothing with the "iss" parameter.

How to Reproduce?

Not sure how to swap out Issuer values halfway through the Auth Code process, but looking at the Keycloak.js shows there's no logic around the "iss" parameter

Anything else?

No response

@jonkoops
Copy link
Contributor

@tnorimat just making sure you are aware of this issue. I'll have to take a look at how much of an effort this would be.

@jonkoops jonkoops transferred this issue from keycloak/keycloak Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants