Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write tests for calling init() more than once #14

Open
jonkoops opened this issue Jul 3, 2023 · 4 comments
Open

Write tests for calling init() more than once #14

jonkoops opened this issue Jul 3, 2023 · 4 comments
Assignees

Comments

@jonkoops
Copy link
Contributor

jonkoops commented Jul 3, 2023

It is not possible to call init() more than once, an exception will be thrown if it is (see implementation under keycloak/keycloak#20722). This behavior is currently not covered by tests.

Under this issue a test must be written that will initialize a Keycloak JS instance twice, and assert that it does in fact throw an exception.

These tests must be added to the existing JavaScriptAdapterTest.

@Ehsanino82
Copy link

i write this pr for this issue keycloak/keycloak#21414

@jonkoops
Copy link
Contributor Author

jonkoops commented Jul 3, 2023

Thanks @Ehsanino82. The changes you made are not exactly what we need (see keycloak/keycloak#21414 (comment)). I've updated the issue to be more descriptive.

@KonarzewskiP
Copy link

Hey @jonkoops , can I take this issue?

@jonkoops
Copy link
Contributor Author

Sure, go right ahead!

@jonkoops jonkoops removed good first issue Good for newcomers help wanted Extra attention is needed labels Jul 14, 2023
@jonkoops jonkoops self-assigned this Oct 10, 2024
@jonkoops jonkoops transferred this issue from keycloak/keycloak Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants