Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for "scope" in JS adapter init options #23

Open
kv979w opened this issue Jun 9, 2022 · 1 comment
Open

Add documentation for "scope" in JS adapter init options #23

kv979w opened this issue Jun 9, 2022 · 1 comment
Assignees
Labels
good first issue Good for newcomers

Comments

@kv979w
Copy link

kv979w commented Jun 9, 2022

Description

The "scope" option is not documented in https://www.keycloak.org/docs/latest/securing_apps/index.html#javascript-adapter-reference even though it exists in the source code here: https://github.com/keycloak/keycloak/blob/3c19ad627f99ff5294b5619e1edc29c4710ae09b/adapters/oidc/js/src/keycloak.js#L151-L153.

Could it be added to the supported options in the documentation repository here: https://github.com/keycloak/keycloak-documentation/blob/main/securing_apps/topics/oidc/javascript-adapter.adoc#properties?

Discussion

No response

Motivation

No response

Details

No response

@stianst stianst transferred this issue from keycloak/keycloak-documentation Mar 20, 2023
@jonkoops jonkoops added the good first issue Good for newcomers label Apr 13, 2023
@jonkoops jonkoops self-assigned this May 11, 2023
@Ines-Belhaj
Copy link

@kv979w @jonkoops Indeed, I have read the documentation, and it lacks some specifications related to the scope part in the JS adapter section. So, I took the liberty and added more details to describe the code you provided. You can check my pull request. You can find it in the following link: keycloak/keycloak#20337

@jonkoops jonkoops transferred this issue from keycloak/keycloak Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants