Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor KeycloakClient to use oauth2 and clientcredentials libraries #148

Closed
fharding1 opened this issue Sep 1, 2019 · 3 comments
Closed
Labels
enhancement New feature or request

Comments

@fharding1
Copy link
Contributor

fharding1 commented Sep 1, 2019

Much of the functionality in KeycloakClient for logging in and refreshing the access token seems to re-implement behavior already implemented in golang.org/x/oauth2 and golang.org/x/oauth2/clientcredentials. This issue includes research into whether those libraries would be sufficient, and refactoring KeycloakClient to use them if they are. I would be happy to take this on.

@mrparkers
Copy link
Contributor

I agree, it would probably be better to use an official OAuth2 implementation rather than one implemented in this project.

Feel free to look into this and submit a PR if this is something you're interested in 😄

Thanks for the issue!

@fharding1
Copy link
Contributor Author

Of course, happy to help out! I actually just submitted a PR to golang/oauth2 that should help out with this (it's still possible to use golang/oauth2 without it but it's a bit more annoying), so I'll see where that goes...

golang/oauth2#396

@mrparkers
Copy link
Contributor

mrparkers commented Sep 2, 2019

Nice, I like the initiative! I think the PR you submitted has valid use cases even without this provider in mind - hopefully the maintainers agree.

@mrparkers mrparkers added the enhancement New feature or request label Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants