Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support POST http method #2

Open
glovebx opened this issue May 8, 2024 · 5 comments
Open

Support POST http method #2

glovebx opened this issue May 8, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@glovebx
Copy link

glovebx commented May 8, 2024

The DownloadService currently only provides a GET method. I hope to add a POST method that can accept parameters annotated with @FieldMap

@khushpanchal
Copy link
Owner

Noted, I will plan for it.👍

@khushpanchal khushpanchal added the enhancement New feature or request label May 8, 2024
@dev-weiqi
Copy link

A small suggestion: maybe we could let users provide their own DownloadService.

@khushpanchal
Copy link
Owner

As DownloadService is used by workmanager, we are only passing minimal info (config, primitive data) to inputData and Workmanager is independently running and downloading the file to disk. I think passing our custom DownloadService is not needed.

@khushpanchal
Copy link
Owner

@glovebx I have made a major change in library with support of pause and resume functionality. Version 2.0.0 , https://github.com/khushpanchal/Ketch
You can check out and try new version.
Feel free to create the PR with the above mentioned functionality, as it was not included in this release.

@glovebx
Copy link
Author

glovebx commented Aug 5, 2024

@glovebx I have made a major change in library with support of pause and resume functionality. Version 2.0.0 , https://github.com/khushpanchal/Ketch You can check out and try new version. Feel free to create the PR with the above mentioned functionality, as it was not included in this release.

Thanks for your great work! I’ll check it out later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants