Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add graphical wait_for_light back in #159

Open
Zacharyprime opened this issue Jul 18, 2022 · 1 comment
Open

Add graphical wait_for_light back in #159

Zacharyprime opened this issue Jul 18, 2022 · 1 comment
Labels
Awaiting PR This task is complete and just awaiting a pull request to get reviewed. Clean Up

Comments

@Zacharyprime
Copy link
Member

I created a ASCII lightbulb replacement for wait_for_light.

There is a ~2 second delay added from this which we had to account for at the tournament.

The graphical library now works on Wombat (afaik) so we should add back the old graphical version to prevent an advantage for Wallabies.
@Zacharyprime
Copy link
Member Author

This may have been done at the tournament but I'm not sure if it's in master or a seperate branch.

Make sure to take a look at what changes were made on different repositories from July 10th to July 16th.

@Zacharyprime Zacharyprime linked a pull request Sep 16, 2022 that will close this issue
Adding back graphical wait_for_light #175
Closed
@Zacharyprime Zacharyprime added the Awaiting PR This task is complete and just awaiting a pull request to get reviewed. label Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Awaiting PR This task is complete and just awaiting a pull request to get reviewed. Clean Up
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding back graphical wait_for_light kipr/libwallaby
1 participant
@Zacharyprime