Skip to content

Commit 366ed82

Browse files
committed
fix 7.3 compatibility, remove testing dep (since it's not in Laravel 6.x)
1 parent f0c4695 commit 366ed82

File tree

3 files changed

+24
-7
lines changed

3 files changed

+24
-7
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ jobs:
4242
- name: Install dependencies
4343
run: |
4444
composer --version
45-
composer require "illuminate/support:${{ matrix.laravel }}" "illuminate/testing:${{ matrix.laravel }}" "orchestra/testbench:${{ matrix.testbench }}" --no-interaction --no-update
45+
composer require "laravel/framework:${{ matrix.laravel }}" "orchestra/testbench:${{ matrix.testbench }}" --no-interaction --no-update
4646
composer update --prefer-dist --no-interaction
4747
composer dump
4848

composer.json

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,19 +13,18 @@
1313
"authors": [
1414
{
1515
"name": "Zack Teska",
16-
"email": "[email protected]"
16+
"email": "[email protected]",
17+
"role": "Developer"
1718
}
1819
],
1920
"require": {
2021
"php": "^7.3",
2122
"illuminate/support": "^6.0|^7.0|^8.0",
22-
"illuminate/testing": "^6.0|^7.0|^8.0",
2323
"league/openapi-psr7-validator": "^0.12.0",
2424
"nyholm/psr7": "^1.3",
2525
"symfony/psr-http-message-bridge": "^2.0"
2626
},
2727
"require-dev": {
28-
"laravel/legacy-factories": "^1.0@dev",
2928
"orchestra/testbench": "4.*|5.*|6.*",
3029
"mockery/mockery": "^1.3.1",
3130
"phpunit/phpunit": "^9.0",

tests/ValidatorBuildAndSetupTest.php

Lines changed: 21 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -108,11 +108,29 @@ public function provideResponseCodes()
108108
yield "Skips 50${i} by default" => [500 + $i, [], true];
109109
}
110110

111-
yield 'Skips other 500s by default (1)' => [fn ($faker) => $faker->numberBetween(505, 599), [], true];
111+
yield 'Skips other 500s by default (1)' => [
112+
function ($faker) {
113+
return $faker->numberBetween(505, 599);
114+
},
115+
[],
116+
true,
117+
];
112118

113-
yield 'Skips other 500s by default (2)' => [fn ($faker) => $faker->numberBetween(505, 599), [], true];
119+
yield 'Skips other 500s by default (2)' => [
120+
function ($faker) {
121+
return $faker->numberBetween(505, 599);
122+
},
123+
[],
124+
true,
125+
];
114126

115-
yield 'Skips other 500s by default (3)' => [fn ($faker) => $faker->numberBetween(505, 599), [], true];
127+
yield 'Skips other 500s by default (3)' => [
128+
function ($faker) {
129+
return $faker->numberBetween(505, 599);
130+
},
131+
[],
132+
true,
133+
];
116134

117135
yield 'Skips single code' => [200, 200, true];
118136

0 commit comments

Comments
 (0)