Skip to content
This repository was archived by the owner on Jun 16, 2024. It is now read-only.

Commit faeb43b

Browse files
committed
mark some things private.
1 parent fcb6259 commit faeb43b

File tree

10 files changed

+14
-13
lines changed

10 files changed

+14
-13
lines changed

src/main/scala/ee/hrzn/chryse/ChryseScallopConf.scala

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import org.rogach.scallop.ScallopConf
44
import org.rogach.scallop.Subcommand
55

66
// TODO (Scallop): Show parent version string on subcommand help.
7-
class ChryseScallopConf(chryse: ChryseApp, args: Array[String])
7+
private[chryse] class ChryseScallopConf(chryse: ChryseApp, args: Array[String])
88
extends ScallopConf(args) {
99
private val appVersion = getClass().getPackage().getImplementationVersion()
1010
val versionBanner = s"${chryse.name} $appVersion (Chryse " +

src/main/scala/ee/hrzn/chryse/ExampleApp.scala

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import ee.hrzn.chryse.platform.ecp5.LFE5U_85F
88
import ee.hrzn.chryse.platform.ecp5.ULX3SPlatform
99
import ee.hrzn.chryse.platform.ice40.IceBreakerPlatform
1010

11-
object ExampleApp extends ChryseApp {
11+
private[chryse] object ExampleApp extends ChryseApp {
1212
class Top(implicit @annotation.unused platform: Platform) extends Module {}
1313

1414
override val name = "example"

src/main/scala/ee/hrzn/chryse/platform/ChryseTop.scala

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import ee.hrzn.chryse.platform.resource.ResourceData
1111
import scala.collection.mutable
1212
import scala.language.existentials
1313

14-
trait ChryseTop extends RawModule {
14+
private[chryse] trait ChryseTop extends RawModule {
1515
override def desiredName = "chrysetop"
1616

1717
case class ConnectedResource(

src/main/scala/ee/hrzn/chryse/platform/cxxrtl/BlackBoxGenerator.scala

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import ee.hrzn.chryse.chisel.specifiedDirectionOf
77

88
import java.io.Writer
99

10-
class BlackBoxGenerator(private val wr: Writer) {
10+
private[chryse] class BlackBoxGenerator(private val wr: Writer) {
1111
// Can we just add attributes somehow and output Verilog instead?
1212
//
1313
// -- I looked into this and there's many levels of things missing:

src/main/scala/ee/hrzn/chryse/platform/ecp5/LPF.scala

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import chisel3.experimental.Param
55
import chisel3.experimental.StringParam
66
import ee.hrzn.chryse.platform.resource.PinString
77

8-
final case class LPF(
8+
final private[chryse] case class LPF(
99
ios: Map[String, (PinString, Map[String, Param])],
1010
freqs: Map[String, BigInt],
1111
) {

src/main/scala/ee/hrzn/chryse/platform/ice40/PCF.scala

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ package ee.hrzn.chryse.platform.ice40
22

33
import ee.hrzn.chryse.platform.resource.PinInt
44

5-
final case class PCF(
5+
final private[chryse] case class PCF(
66
ios: Map[String, PinInt],
77
freqs: Map[String, BigInt],
88
) {

src/main/scala/ee/hrzn/chryse/platform/resource/SPI.scala

+5-4
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import chisel3.experimental.Param
66
class SPI extends ResourceBase {
77
// TODO: DSPI, QSPI
88

9-
val cs = ResourceData(Output(Bool()), invert = true)
9+
val cs = ResourceData(Output(Bool()), invert = true) // permitted to be unset
1010
val clock = ResourceData(Output(Clock()))
1111
val copi = ResourceData(Output(Bool()))
1212
val cipo = ResourceData(Input(Bool()))
@@ -42,14 +42,15 @@ class SPI extends ResourceBase {
4242
}
4343

4444
def onPins(
45-
csN: Pin,
45+
csN: Pin = null,
4646
clock: Pin,
4747
copi: Pin,
4848
cipo: Pin,
4949
wpN: Pin = null,
5050
holdN: Pin = null,
5151
): this.type = {
52-
this.cs.onPin(csN)
52+
if (csN != null)
53+
this.cs.onPin(csN)
5354
this.clock.onPin(clock)
5455
this.copi.onPin(copi)
5556
this.cipo.onPin(cipo)
@@ -61,7 +62,7 @@ class SPI extends ResourceBase {
6162
}
6263

6364
def data: Seq[ResourceData[_ <: Data]] =
64-
Seq(cs, clock, copi, cipo) ++ Seq(wp, hold).filter(_.pinId.isDefined)
65+
Seq(clock, copi, cipo) ++ Seq(cs, wp, hold).filter(_.pinId.isDefined)
6566
}
6667

6768
object SPI {

src/main/scala/ee/hrzn/chryse/tasks/BuildTask.scala

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import ee.hrzn.chryse.platform.PlatformBoardResources
88
import java.nio.file.Files
99
import java.nio.file.Paths
1010

11-
object BuildTask extends BaseTask {
11+
private[chryse] object BuildTask extends BaseTask {
1212
case class Options(
1313
program: Boolean,
1414
programMode: String,

src/main/scala/ee/hrzn/chryse/tasks/CxxsimTask.scala

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import java.nio.file.Paths
1313
import scala.collection.mutable
1414
import scala.sys.process._
1515

16-
object CxxsimTask extends BaseTask {
16+
private[chryse] object CxxsimTask extends BaseTask {
1717
private val cxxsimDir = "cxxsim"
1818
private val baseCxxOpts = Seq("-std=c++17", "-g", "-pedantic", "-Wall",
1919
"-Wextra", "-Wno-zero-length-array", "-Wno-unused-parameter")

src/main/scala/ee/hrzn/chryse/verilog/InterfaceExtractor.scala

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ package ee.hrzn.chryse.verilog
33
import scala.collection.mutable
44
import scala.util.matching.Regex
55

6-
object InterfaceExtractor {
6+
private[chryse] object InterfaceExtractor {
77
private val reWhole: Regex =
88
(raw"(?m)^module (\w+)\(" +
99
raw"((?:\s*,?(?:\s*(?:input|output|inout)\s)?" +

0 commit comments

Comments
 (0)