Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nginx-ingress integration #4

Open
kfox1111 opened this issue Apr 26, 2019 · 3 comments
Open

nginx-ingress integration #4

kfox1111 opened this issue Apr 26, 2019 · 3 comments
Labels
enhancement New feature or request

Comments

@kfox1111
Copy link

This is a really interesting project. :)

Feature idea, what if the controller could also drive nginx-ingress ingress rules and an oauth2 deployment to plugin the authentication into the process. Maybe that is a different crd, or an annotation on an ingress?

It would make it significantly easier to not only get a client but also start using it.

@axdotl
Copy link
Contributor

axdotl commented Apr 26, 2019

Hi @kfox1111
I'm not really get your point. Could you explain it in a little more detail?

@kfox1111
Copy link
Author

so, for example, see https://github.com/kubernetes/ingress-nginx/tree/master/docs/examples/auth/oauth-external-auth (and maybe https://github.com/kubernetes/ingress-nginx/blob/master/docs/examples/auth/oauth-external-auth/oauth2-proxy.yaml)

This plugs in oauth2_proxy into nginx-ingress as a pure auth plugin.

I'm thinking keycloak-client-controller has enough information to launch the authentication bits for the user to go along with the client bits that it is retrieving?

So, maybe the user puts in a few config options in the CustomResource and it automatically provisions the auth plugin for them?

That would allow the user to focus on developing their website, and through a k8s object can get the whole security layer added for them.

@axdotl
Copy link
Contributor

axdotl commented Apr 30, 2019

Got it, and I support this idea.
But as this actually not fit to our scenario (we're using traefik and keycloak-gatekeeper), we'll not implement this soon.

I'll let this issue open and maybe someone else will implement this and create a PR.
Thanks for the idea!

@axdotl axdotl added the enhancement New feature or request label Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants