You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We should either support getting the image size in that method, and/or allow some way to pass along that information in OpdsEntryNavigation and OpdsEntryBook - right now the constructor uses ?string
Nothing urgent, but I noticed that on Android the Readium demo app didn't like showing images on a small device with OPDS 2.0. I'm not sure if the width/height is the issue or something else...
The text was updated successfully, but these errors were encountered:
What happened?
In OPDS 2.0 images MAY include any number of image format, resolution or aspect ratio - see https://drafts.opds.io/opds-2.0#23-images
The current php-opds implementation uses hard-coded values for width and height:
php-opds/src/Engine/OpdsJsonEngine.php
Line 173 in 790eec9
We should either support getting the image size in that method, and/or allow some way to pass along that information in
OpdsEntryNavigation
andOpdsEntryBook
- right now the constructor uses?string
php-opds/src/Entries/OpdsEntryBook.php
Line 23 in 790eec9
How to reproduce the bug
Generate OPDS 2.0 feed
Package Version
2.1.0
PHP Version
8.2
Which operating systems does with happen with?
Linux
Notes
Nothing urgent, but I noticed that on Android the Readium demo app didn't like showing images on a small device with OPDS 2.0. I'm not sure if the width/height is the issue or something else...
The text was updated successfully, but these errors were encountered: