-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FinalPrice pushed as exclude tax from PDP #312
Labels
Comments
some extra info: our client has conversation with support and they given the following answer:
|
This was referenced Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Environment details
PHP version: 8.1.28
Magento version: 2.4.5-p9
Klaviyo extension version: 4.1.3
(Magento Cloud, so please do not judge the php version)
Steps to reproduce
Visit PDP
check the rendered klaviyo.push payload: discrepancy in FinalPrice and the rendered price for the end customer
Expected result
FinalPrice is set to be the same as the rendered price
OR
the FinalPrice should follow the visibility setting of product price
Actual result
final price without tax added to JSON payload
Additional information
https://github.com/klaviyo/magento2-klaviyo/blob/master/Block/Catalog/Product/ViewedProduct.php#L161
when this being changed to use
getAmount()->getValue()
on the final price object - instead ofgetValue()
, the include tax price being added as FinalPricealso, please see
https://belvg.com/blog/the-functionality-and-basic-concepts-of-price-generation-in-magento-2.html
The text was updated successfully, but these errors were encountered: