Skip to content

Commit 0890bff

Browse files
authored
Merge pull request #7 from knation/v1.0.2
v1.0.2
2 parents 3677129 + b38b3f6 commit 0890bff

File tree

5 files changed

+134
-15
lines changed

5 files changed

+134
-15
lines changed

.npmignore

Lines changed: 107 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,107 @@
1+
# Logs
2+
logs
3+
*.log
4+
npm-debug.log*
5+
yarn-debug.log*
6+
yarn-error.log*
7+
lerna-debug.log*
8+
9+
# Diagnostic reports (https://nodejs.org/api/report.html)
10+
report.[0-9]*.[0-9]*.[0-9]*.[0-9]*.json
11+
12+
# Runtime data
13+
pids
14+
*.pid
15+
*.seed
16+
*.pid.lock
17+
18+
# Directory for instrumented libs generated by jscoverage/JSCover
19+
lib-cov
20+
21+
# Coverage directory used by tools like istanbul
22+
coverage
23+
*.lcov
24+
25+
# nyc test coverage
26+
.nyc_output
27+
28+
# Grunt intermediate storage (https://gruntjs.com/creating-plugins#storing-task-files)
29+
.grunt
30+
31+
# Bower dependency directory (https://bower.io/)
32+
bower_components
33+
34+
# node-waf configuration
35+
.lock-wscript
36+
37+
# Compiled binary addons (https://nodejs.org/api/addons.html)
38+
build/Release
39+
40+
# Dependency directories
41+
node_modules/
42+
jspm_packages/
43+
44+
# TypeScript v1 declaration files
45+
typings/
46+
47+
# TypeScript cache
48+
*.tsbuildinfo
49+
50+
# Optional npm cache directory
51+
.npm
52+
53+
# Optional eslint cache
54+
.eslintcache
55+
56+
# Microbundle cache
57+
.rpt2_cache/
58+
.rts2_cache_cjs/
59+
.rts2_cache_es/
60+
.rts2_cache_umd/
61+
62+
# Optional REPL history
63+
.node_repl_history
64+
65+
# Output of 'npm pack'
66+
*.tgz
67+
68+
# Yarn Integrity file
69+
.yarn-integrity
70+
71+
# dotenv environment variables file
72+
.env
73+
.env.test
74+
75+
# parcel-bundler cache (https://parceljs.org/)
76+
.cache
77+
78+
# Next.js build output
79+
.next
80+
81+
# Nuxt.js build / generate output
82+
.nuxt
83+
dist
84+
85+
# Gatsby files
86+
.cache/
87+
# Comment in the public line in if your project uses Gatsby and *not* Next.js
88+
# https://nextjs.org/blog/next-9-1#public-directory-support
89+
# public
90+
91+
# vuepress build output
92+
.vuepress/dist
93+
94+
# Serverless directories
95+
.serverless/
96+
97+
# FuseBox cache
98+
.fusebox/
99+
100+
# DynamoDB Local files
101+
.dynamodb/
102+
103+
# TernJS port file
104+
.tern-port
105+
106+
test/
107+
.github/

index.js

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,14 @@ class DelayedTasks {
6363
this.pollIntervalId = null;
6464
}
6565

66+
/**
67+
* Closes up shop.
68+
*/
69+
close() {
70+
this.stop();
71+
this.redisClient.quit();
72+
}
73+
6674
/**
6775
* Polls redis for tasks.
6876
*/

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "redis-delayed-tasks",
3-
"version": "1.0.1",
3+
"version": "1.0.2",
44
"description": "Allows for the future execution of tasks utilizing redis as a datastore.",
55
"main": "index.js",
66
"scripts": {

test/test.js

Lines changed: 16 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -396,23 +396,27 @@ describe('add()', function() {
396396

397397
});
398398

399-
describe('start/stop', function() {
399+
it('start/stop/close', function() {
400+
const dt = createTasksObject();
400401

401-
it('starts/stops the polling', function() {
402-
const dt = createTasksObject();
402+
// Should be null after init
403+
assert.equal(dt.pollIntervalId, null);
403404

404-
// Should be null after init
405-
assert.equal(dt.pollIntervalId, null);
405+
// Is the interval ID after start()
406+
dt.start();
407+
assert.ok(dt.pollIntervalId);
406408

407-
// Is the interval ID after start()
408-
dt.start();
409-
assert.ok(dt.pollIntervalId);
409+
// Is empty after stop
410+
dt.stop();
411+
assert.equal(dt.pollIntervalId, null);
410412

411-
// Is empty after stop
412-
dt.stop();
413-
assert.equal(dt.pollIntervalId, null);
414-
});
413+
// Start again
414+
dt.start();
415+
assert.ok(dt.pollIntervalId);
415416

417+
// Close and test interval again
418+
dt.close();
419+
assert.equal(dt.pollIntervalId, null);
416420
});
417421

418422
describe('poll', function() {

0 commit comments

Comments
 (0)