-
Notifications
You must be signed in to change notification settings - Fork 0
Labels
bugSomething isn't workingSomething isn't workingenhancementNew feature or requestNew feature or request
Description
Goal
Ensure keystone-cli --help output does not expose CancellationToken as a user-facing argument (e.g., --cancellation-token) for any command.
Scope
- Audit all Cocona command implementations and identify any methods that accept
CancellationTokenin the signature and therefore surface it in help output - Determine the preferred approach:
- remove
CancellationTokenfrom command method signatures where it’s not needed, or - suppress/hide it from Cocona-generated help output (if Cocona supports this)
- remove
- Apply the chosen approach consistently across all commands
- Add a unit test that scans command methods via reflection to enforce the rule:
CancellationTokenis not present in command method parameters unless it is explicitly suppressed from help output
Outcome
- CLI help output contains only user-actionable arguments
- No command lists --cancellation-token (or similar) in help text
- A regression test prevents this from reappearing in future commands
Notes
- This is a UX/ergonomics improvement, not a behavior change.
- If Cocona doesn’t support suppression, standardize on “don’t include CancellationToken in command signatures” and document the convention.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingenhancementNew feature or requestNew feature or request