Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] fairness_selection and model_fairness functions #207

Open
lottemensink opened this issue Feb 18, 2025 · 1 comment
Open

[Bug] fairness_selection and model_fairness functions #207

lottemensink opened this issue Feb 18, 2025 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@lottemensink
Copy link
Contributor

I have a few remarks after testing the fairness_selection and the model_fairness functions.

When I use the following code it skips question 3. I know that this is because of the decision-workflow, but I wonder whether it warrants a warning?

select <- fairness_selection(q1 = "1", q2 = "2", q3 = "2", q4 = "2")

In the compas dataset included in the package, one variable is called "AgeAboveFoutryFive" which should be "AgeAboveFourtyFive" I think (not really a big issue though)

Furthermore, summary(select) looks like this. It might be nice to have a written summary of the selected measure here, but maybe not strictly necessary

Image

Should this code give an error? This error message seems to be informative, but I do not really understand why the equalized odds cannot be provided by this function. Is it not possible to provide tprp and fprp as output for this function? Maybe I am misunderstanding something.

Image
@lottemensink lottemensink added the bug Something isn't working label Feb 18, 2025
@koenderks koenderks self-assigned this Feb 18, 2025
@koenderks
Copy link
Owner

I changed the AgeAboveFoutryFive to AgeAboveFourtyFive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants