Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Use Icons Instead of Using Plain Text for Describing Type of Plugins #117

Closed
MaikoTan opened this issue Nov 6, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@MaikoTan
Copy link
Member

MaikoTan commented Nov 6, 2023

我们提供了四种插件标识,它们本身也是过滤条件。包括:
- `is:verified`:官方认证 (对钩)
- `is:insecure`:不安全 (叹号)
- `is:preview`:开发中 (扳手)
- `created:>date`:近期新增 (树苗)

Here, various types of plugins are listed with their display styles and icons in the plugin marketplace. However, text-based representation may not be very intuitive. I believe it can be replaced with the same set of icons used in the plugin marketplace.

这里列出了插件市场中各种类型的插件及其显示样式和图标。然而,基于文本的表示可能不是很直观。我相信它可以替换为插件市场中使用的同一组图标。

@MaikoTan MaikoTan added the enhancement New feature or request label Nov 6, 2023
@MaikoTan
Copy link
Member Author

MaikoTan commented Nov 6, 2023

I delved into Koishi's documentation and the market code and found that they are in the form of SVGs within Vue files. This leads to two possible solutions:

  1. Copy the icons from the market into the documentation and then register these components in the enhanceApp function.
  2. Keep the icons in the market project. I'll write a component that imports Vue components from the market project and then displays the appropriate icons based on parameters.

Currently, I think option 2 would be more suitable. What do you think?

我深入研究了 Koishi 的文档和市场代码,发现它们在 Vue 文件中采用 SVG 的形式。这导致两种可能的解决方案:

  1. 将市场上的图标复制到文档中,然后将这些组件注册到enhanceApp函数中。
  2. 保留市场项目中的图标。我将编写一个组件,从市场项目中导入 Vue 组件,然后根据参数显示适当的图标。

目前,我认为方案2更合适。你怎么认为?

@shigma
Copy link
Member

shigma commented Dec 8, 2023

#132

@shigma shigma closed this as completed Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants