Escalate privileges with sudo

[gsuyemoto]

Hey! Great project and thanks for all the work! I use the sudo crate for a bunch of my projects and thought it could be useful for this project as well. Just a one-liner and you can provide the user with, IMHO, a nicer experience by being able to upgrade to sudo without having to exit and then rerun the app. I can submit a pull request if needed. Thanks again for the great work!

[Saluki]

Hello @gsuyemoto ! Thank you for the feedback 👍
Great idea, adding the sudo crate could indeed be a nice improvement to the project - do you want to open a PR ?

[gsuyemoto]

Hey Corentin, Sure, I can submit a PR. I haven't submitted a PR to any other project, so I'm a noob! I have a branch set up with the changes: - Added sudo crate to Cargo.toml => sudo = "0.6" - Modified main.rs to add sudo call at the very beginning of main() - Removed call to function that checks for sudo privileges in main() - Removed function for checking sudo privileges in utils.rs - Removed use::std::env in utils.rs as the sudo function seemed to be the only code needing it Please let me know if I'm missing anything. Gary

…

On Wed, May 3, 2023 at 4:38 AM Corentin B. ***@***.***> wrote: Hello @gsuyemoto <https://github.com/gsuyemoto> ! Thank you for the feedback 👍 Great idea, adding the sudo crate could indeed be a nice improvement to the project - do you want to open a PR ? — Reply to this email directly, view it on GitHub <#4 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AE5S556BXPU2B2KWRHQKM3DXEI7UZANCNFSM6AAAAAAXTSXLG4> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[Saluki]

Thanks for the PR @gsuyemoto - that was fast 👍 I will close this thread and move the discussion to #5 before merging