[TECH DEBT] Follow up to remove unnecessary TS generics when TS language supports partial type param inference

[mturley]

TypeScript generic type param lists are currently all-or-nothing. When passing type params to a function, you must either omit the list and allow all generics to be inferred or pass them all explicitly. This means if some of your types can be inferred from function arguments and some cannot, you need to explicitly repeat all the types including the infer-able ones. This is especially annoying when an inferred type is a long-winded string union such as is the case with the key properties in an array of FilterCategories. This occasionally makes for some quite redundant code, although TypeScript will still enforce that it is all consistent.

There is a possible upcoming TypeScript language feature which would allow partial inference in type param lists and may alleviate this in the future. See TypeScript pull requests #26349 and #54047. If and when this feature is available in TypeScript, we should upgrade to that version and remove the unnecessary repetition in our code.

Some examples of where this repetition is present:

• tackle2-ui/client/src/app/pages/controls/tags/tags.tsx

  Line 170 in 82de730

  "tags" | "rank" | "color"

• tackle2-ui/client/src/app/pages/reports/components/identified-risks-table/identified-risks-table.tsx

  Line 105 in 82de730

  "category" | "question" | "answer" | "applications"

• tackle2-ui/client/src/app/pages/controls/job-functions/job-functions.tsx

  Line 62 in 82de730

  const filterCategories: FilterCategory<JobFunction, "name">[] = [

• tackle2-ui/client/src/app/pages/reports/components/adoption-candidate-table/adoption-candidate-table.tsx

  Line 167 in 82de730

  const filterCategories: FilterCategory<TableRowData, "name">[] = [

• tackle2-ui/client/src/app/pages/applications/analysis-wizard/custom-rules.tsx

  Line 119 in 82de730

  const filterCategories: FilterCategory<IReadFile, "name">[] = [

• tackle2-ui/client/src/app/pages/applications/manage-imports/manage-imports.tsx

  Line 100 in 82de730

  "filename"

• tackle2-ui/client/src/app/pages/controls/stakeholder-groups/stakeholder-groups.tsx

  Line 124 in 82de730

  "name" | "description" | "stakeholders"

• tackle2-ui/client/src/app/pages/identities/identities.tsx

  Line 110 in 82de730

  "name" | "type" | "createdBy"

• tackle2-ui/client/src/app/pages/review/components/application-assessment-summary-table/application-assessment-summary-table.tsx

  Line 84 in 82de730

  const filterCategories: FilterCategory<ITableItem, "riskValue">[] = [

• tackle2-ui/client/src/app/pages/applications/components/application-tags/application-tags.tsx

  Line 129 in 82de730

  "source" | "tagCategory"

• tackle2-ui/client/src/app/pages/applications/components/application-detail-drawer/application-facts.tsx

  Line 34 in 82de730

  const filterCategories: FilterCategory<Fact, "source">[] = [

• tackle2-ui/client/src/app/pages/controls/business-services/business-services.tsx

  Line 89 in 82de730

  "name" | "description" | "owner"

• tackle2-ui/client/src/app/pages/applications/manage-imports-details/manage-imports-details.tsx

  Line 101 in 82de730

  "Application Name"

This also causes awkwardness when using the table-control hooks, particularly when calling useTableControlState, because the TItem type (the type of the actual API object items) cannot be inferred from arguments and the list of type params that would have to be passed to that hook is quite long. We made the decision to not pass any type params there, which means TItem gets resolved to unknown. This is mostly fine for this case, but it would be good to be able to explicitly pass TItem without passing all the other types. See comments at https://github.com/konveyor/tackle2-ui/blob/main/client/src/app/hooks/table-controls/types.ts#L28-L32.

[konveyor-ci-bot]

This issue is currently awaiting triage.
If contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members.