Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] .join("") could result in false positives within filter string creation #1827

Open
1 task done
ibolton336 opened this issue Apr 5, 2024 · 2 comments
Open
1 task done

[BUG] .join("") could result in false positives within filter string creation #1827

ibolton336 opened this issue Apr 5, 2024 · 2 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. priority/normal Higher priority than priority/minor. Nice to have. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@ibolton336
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

Konveyor version

latest

Priority

Critical

Current Behavior

Probably should be .join("^") or some name invalid character so the oddball false positive matches won't happen. "RedItchy" will match "ditch" but "Red^Itchy" will not.

Expected Behavior

No response

How Reproducible

Always (Default)

Steps To Reproduce

No response

Environment

- OS:

Anything else?

No response
@ibolton336 ibolton336 added kind/bug Categorizes issue or PR as related to a bug. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. approved labels Apr 5, 2024
@konveyor-ci-bot konveyor-ci-bot bot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Apr 5, 2024
@konveyor-ci-bot
Copy link

This issue is currently awaiting triage.
If contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members.

@konveyor-ci-bot
Copy link

This issue has been marked 'good first issue'
Please, make sure it aligns with the criteria found here

@konveyor-ci-bot konveyor-ci-bot bot added the needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. label Apr 5, 2024
@ibolton336 ibolton336 mentioned this issue Apr 5, 2024
Merged
@sjd78 sjd78 added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/normal Higher priority than priority/minor. Nice to have. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. labels May 15, 2024
@sjd78 sjd78 removed the approved label Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. priority/normal Higher priority than priority/minor. Nice to have. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Planning
Status: 🔖 Ready
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sjd78 @ibolton336