Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate metrics warning during testing #299

Closed
marcosschroh opened this issue Mar 13, 2025 · 1 comment
Closed

Investigate metrics warning during testing #299

marcosschroh opened this issue Mar 13, 2025 · 1 comment
Assignees
@marcosschroh

Comments

@marcosschroh
Copy link
Collaborator

There is a warning when the end users is performing tests using kstreams

task: <Task pending name='Task-2853' coro=<PrometheusMonitor.start() running at /Users/eigenein/Git/de-fixed/.venv/lib/python3.12/site-packages/kstreams/prometheus/monitor.py:67> wait_for=<Future pending cb=[Task.task_wakeup()]>>

The warning happens because there are not references to background asyncio tasks like the monitoring one. It is likely that for the Streams happens the same thing.

Expected behavior:

Ideally when the StreamEngine is stopped the monitoring task should be awaited until complete to avoid the warning.
marcosschroh added a commit that referenced this issue Mar 13, 2025
@marcosschroh
fix: stop monitoring background task using asyncio.Event primitive. R…
a22356e 
…elated to #299
@marcosschroh marcosschroh mentioned this issue Mar 13, 2025
Merged
marcosschroh added a commit that referenced this issue Mar 18, 2025
@marcosschroh
fix: stop monitoring background task using asyncio.Event primitive. R…
77a1a16 
…elated to #299
marcosschroh added a commit that referenced this issue Mar 18, 2025
@marcosschroh
fix: stop monitoring background task using asyncio.Event primitive. R…
b81afe3 
…elated to #299
marcosschroh added a commit to marcosschroh/kstreams that referenced this issue Mar 18, 2025
@marcosschroh
fix: stop monitoring background task using asyncio.Event primitive. R…
660eeeb 
…elated to kpn#299
marcosschroh added a commit that referenced this issue Mar 18, 2025
@marcosschroh
fix: stop monitoring background task using asyncio.Event primitive. R…
6235eca 
…elated to #299
marcosschroh added a commit that referenced this issue Mar 18, 2025
@marcosschroh
fix: stop properly asyncio.Tasks that run in background mode (streams…
57162f7 
… and monitoring). Related to #299
marcosschroh added a commit that referenced this issue Mar 18, 2025
@marcosschroh
fix: stop properly asyncio.Tasks that run in background mode (streams…
3fae4b8 
… and monitoring). Related to #299
marcosschroh added a commit that referenced this issue Mar 19, 2025
@marcosschroh
fix: stop properly asyncio.Tasks that run in background mode (streams…
62b3636 
… and monitoring). Related to #299
marcosschroh added a commit that referenced this issue Mar 19, 2025
@marcosschroh
fix: stop properly asyncio.Tasks that run in background mode (streams…
6b02916 
… and monitoring). Related to #299 (#300)
@marcosschroh marcosschroh self-assigned this Mar 19, 2025
@marcosschroh
Copy link
Collaborator Author

closed by #300

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcosschroh marcosschroh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@marcosschroh