Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Badge image being used instead of uploaded photo #13

Open
richardmtl opened this issue Dec 29, 2020 · 3 comments
Open

Badge image being used instead of uploaded photo #13

richardmtl opened this issue Dec 29, 2020 · 3 comments

Comments

@richardmtl
Copy link

I'm testing on my test site. See this post:

https://reviewmysite.ca/beers/unibroue-terrible/

It shows the badge image instead of the image I uploaded, even though the image I uploaded is included in the gallery.

Related: #11

@kraftbj
Copy link
Owner

kraftbj commented Jan 6, 2021

For this beer, do you have multiple check-ins with it? Was the last check-in one where you earned a badge but didn't take a picture of it?

I ask because it is supposed to attach badges first, then the picture last to have the picture persist as the thumbnail.

@richardmtl
Copy link
Author

FYI I deleted the site. I definitely have multiple checkins with it, and I did take an image for my last checkin (the most recent one, the one from that post). Do you mean the checkin PRIOR to that one?

@kraftbj
Copy link
Owner

kraftbj commented Jan 6, 2021

What it should do is:

  1. first check-in to a new beer -- creates a new post, then upload any badges, then upload any pictures.
  2. following check-ins -- find the existing post, upload any badges, upload any pictures.

They're uploaded by directly making them the thumbnail, so for the split second, each uploaded pictures becomes a thumbnail... so the last one uploaded should be the thumbnail that we see.

So, if your last check-in of a beer awards a badge but you didn't take a picture, then the badge should be the thumbnail. Should be. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants