Skip to content

Commit 3e7ebf5

Browse files
trueptolemyberrange
authored andcommitted
scripts/cpu-x86-uarch-abi.py: Fix parameter error of cmd
When run this script, there's the error: python3 scripts/cpu-x86-uarch-abi.py /tmp/qmp Traceback (most recent call last): File "/path-to-qemu/qemu/scripts/cpu-x86-uarch-abi.py", line 96, in <module> cpu = shell.cmd("query-cpu-model-expansion", TypeError: QEMUMonitorProtocol.cmd() takes 2 positional arguments but 3 were given Commit 7f521b0 ("scripts/cpu-x86-uarch-abi.py: use .command() instead of .cmd()") converts the the original .cmd() to .command() (which was later renamed to "cmd" to replace the original one). But the new .cmd() only accepts typing.Mapping as the parameter instead of typing.Dict (see _qmp.execute()). Change the paremeters of "query-cpu-model-expansion" to typing.Mapping format to fix this error. Fixes: 7f521b0 ("scripts/cpu-x86-uarch-abi.py: use .command() instead of .cmd()") Reviewed-by: Vladimir Sementsov-Ogievskiy <[email protected]> Signed-off-by: Zhao Liu <[email protected]> Signed-off-by: Daniel P. Berrangé <[email protected]>
1 parent cc9118f commit 3e7ebf5

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

scripts/cpu-x86-uarch-abi.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,8 +94,8 @@
9494

9595
for name in sorted(names):
9696
cpu = shell.cmd("query-cpu-model-expansion",
97-
{ "type": "static",
98-
"model": { "name": name }})
97+
type="static",
98+
model={ "name": name })
9999

100100
got = {}
101101
for (feature, present) in cpu["model"]["props"].items():

0 commit comments

Comments
 (0)