Merge remote-tracking branch 'refs/remotes/origin/main' #209
matt-edmondsondotnet.yml
on: push
Build, Test & Release
2m 48s
Annotations
10 errors and 11 warnings
|
Build, Test & Release:
Keybinding.Core/Services/KeybindingService.cs#L21
Use 'Ensure.NotNull(profileManager)' instead of manual null check with ArgumentNullException
|
|
Build, Test & Release:
Keybinding.Core/Models/KeybindingConfiguration.cs#L43
Use 'Ensure.NotNull(defaultProfileName)' instead of manual null check with ArgumentNullException
|
|
Build, Test & Release:
Keybinding.Core/Models/KeybindingConfiguration.cs#L42
Use 'Ensure.NotNull(defaultProfileId)' instead of manual null check with ArgumentNullException
|
|
Build, Test & Release:
Keybinding.Core/Models/KeybindingConfiguration.cs#L41
Use 'Ensure.NotNull(dataDirectory)' instead of manual null check with ArgumentNullException
|
|
Build, Test & Release:
Keybinding.Core/KeybindingManager.cs#L43
Use 'Ensure.NotNull(repository)' instead of manual null check with ArgumentNullException
|
|
Build, Test & Release:
Keybinding.Core/KeybindingManager.cs#L42
Use 'Ensure.NotNull(profileManager)' instead of manual null check with ArgumentNullException
|
|
Build, Test & Release:
Keybinding.Core/KeybindingManager.cs#L41
Use 'Ensure.NotNull(commandRegistry)' instead of manual null check with ArgumentNullException
|
|
Build, Test & Release:
Keybinding.Core/Services/KeybindingManagerFactory.cs#L27
Use 'Ensure.NotNull(serviceProvider)' instead of manual null check with ArgumentNullException
|
|
Build, Test & Release:
Keybinding.Core/Services/KeybindingService.cs#L21
Use 'Ensure.NotNull(profileManager)' instead of manual null check with ArgumentNullException
|
|
Build, Test & Release:
Keybinding.Core/Services/KeybindingService.cs#L20
Use 'Ensure.NotNull(commandRegistry)' instead of manual null check with ArgumentNullException
|
|
Build, Test & Release
No files were found with the provided path: ./coverage/*. No artifacts will be uploaded.
|
|
Build, Test & Release:
Keybinding.Core/Models/ProfileName.cs#L26
Extract this nested ternary operation into an independent statement. (https://rules.sonarsource.com/csharp/RSPEC-3358)
|
|
Build, Test & Release:
Keybinding.Core/Models/ProfileName.cs#L25
Extract this nested ternary operation into an independent statement. (https://rules.sonarsource.com/csharp/RSPEC-3358)
|
|
Build, Test & Release:
Keybinding.Core/Services/KeybindingService.cs#L41
Remove this argument from the method call; it hides the caller information. (https://rules.sonarsource.com/csharp/RSPEC-3236)
|
|
Build, Test & Release:
Keybinding.Core/Services/KeybindingManagerFactory.cs#L60
Merge this if statement with the enclosing one. (https://rules.sonarsource.com/csharp/RSPEC-1066)
|
|
Build, Test & Release:
Keybinding.Core/Services/ProfileManager.cs#L84
Extract this nested ternary operation into an independent statement. (https://rules.sonarsource.com/csharp/RSPEC-3358)
|
|
Build, Test & Release:
Keybinding.Core/Services/ProfileManager.cs#L37
Define a constant instead of using this literal 'Profile ID cannot be null or whitespace' 6 times. (https://rules.sonarsource.com/csharp/RSPEC-1192)
|
|
Build, Test & Release:
Keybinding.Core/Models/Profile.cs#L70
Define a constant instead of using this literal 'Command ID cannot be null or whitespace' 4 times. (https://rules.sonarsource.com/csharp/RSPEC-1192)
|
|
Build, Test & Release:
Keybinding.Core/Models/MusicalTypes.cs#L172
Define a constant instead of using this literal 'COMMAND' 4 times. (https://rules.sonarsource.com/csharp/RSPEC-1192)
|
|
Build, Test & Release:
Keybinding.Core/Models/MusicalTypes.cs#L172
Define a constant instead of using this literal 'WINDOWS' 4 times. (https://rules.sonarsource.com/csharp/RSPEC-1192)
|
|
Build, Test & Release:
Keybinding.Core/Models/MusicalTypes.cs#L172
Define a constant instead of using this literal 'CONTROL' 4 times. (https://rules.sonarsource.com/csharp/RSPEC-1192)
|