Skip to content

Commit 7ea5430

Browse files
authored
chore: update supported platforms for multi-arch builds (#569)
After discussion with the Kubeflow WG lead - concerns were raised about including `linux/s390x` support in our multi-arch builds for the following reasons: - not clear we could in good faith support this system due to lack of hardware / potential emulation issues - not clear there is enough of a need from community to support `linux/s390x` for Kubeflow Notebooks. As a result - we are going to remove the `linux/s390x` target from our multi-arch builds logic. Additionally, included a minor fix to explicitly specify the `v8` variant of `linux/arm64`. Today `linux/arm64` and `linux/arm64/v8` are essentially the same - but that could change if there was ever a `v9` variant introduced. As such - opting to be explicit here. Signed-off-by: Andy Stoneberg <[email protected]>
1 parent fa5fb5a commit 7ea5430

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

workspaces/backend/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ docker-push: ## Push docker image with the backend.
104104
# - have enabled BuildKit. More info: https://docs.docker.com/develop/develop-images/build_enhancements/
105105
# - be able to push the image to your registry (i.e. if you do not set a valid value via IMG=<myregistry/image:<tag>> then the export will fail)
106106
# To adequately provide solutions that are compatible with multiple platforms, you should consider using this option.
107-
PLATFORMS ?= linux/arm64,linux/amd64,linux/s390x,linux/ppc64le
107+
PLATFORMS ?= linux/arm64/v8,linux/amd64,linux/ppc64le
108108
.PHONY: docker-buildx
109109
docker-buildx: ## Build and push docker image for the manager for cross-platform support
110110
# copy existing Dockerfile and insert --platform=${BUILDPLATFORM} into Dockerfile.cross, and preserve the original Dockerfile

workspaces/controller/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ docker-push: ## Push docker image with the manager.
114114
# - have enabled BuildKit. More info: https://docs.docker.com/develop/develop-images/build_enhancements/
115115
# - be able to push the image to your registry (i.e. if you do not set a valid value via IMG=<myregistry/image:<tag>> then the export will fail)
116116
# To adequately provide solutions that are compatible with multiple platforms, you should consider using this option.
117-
PLATFORMS ?= linux/arm64,linux/amd64,linux/s390x,linux/ppc64le
117+
PLATFORMS ?= linux/arm64/v8,linux/amd64,linux/ppc64le
118118
.PHONY: docker-buildx
119119
docker-buildx: ## Build and push docker image for the manager for cross-platform support
120120
# copy existing Dockerfile and insert --platform=${BUILDPLATFORM} into Dockerfile.cross, and preserve the original Dockerfile

workspaces/frontend/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ docker-push: ## Push docker image for the frontend.
3939
$(CONTAINER_TOOL) push ${IMG}
4040

4141
# PLATFORMS defines the target platforms for cross-platform support.
42-
PLATFORMS ?= linux/arm64,linux/amd64,linux/s390x,linux/ppc64le
42+
PLATFORMS ?= linux/arm64/v8,linux/amd64,linux/ppc64le
4343

4444
.PHONY: docker-buildx
4545
docker-buildx: ## Build and push docker image for cross-platform support.

0 commit comments

Comments
 (0)