Skip to content

Commit f2ed684

Browse files
author
Liav Weiss (EXT-Nokia)
committed
Migrate shared test/quality related workflows from kubeflow/kubeflow to notebooks-v1 branch
Signed-off-by: Liav Weiss (EXT-Nokia) <[email protected]>
1 parent 5f191bc commit f2ed684

File tree

4 files changed

+82
-0
lines changed

4 files changed

+82
-0
lines changed
Lines changed: 53 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,53 @@
1+
name: Common Frontend Tests
2+
on:
3+
pull_request:
4+
paths:
5+
- components/crud-web-apps/common/frontend/kubeflow-common-lib/**
6+
- releasing/version/VERSION
7+
branches:
8+
- v*-branch
9+
- notebooks-v1
10+
11+
jobs:
12+
frontend-format-lint-check:
13+
name: Check code format and lint
14+
runs-on: ubuntu-22.04
15+
16+
steps:
17+
- name: Check out code
18+
uses: actions/checkout@v4
19+
20+
- name: Setup Node
21+
uses: actions/setup-node@v4
22+
with:
23+
node-version: 16
24+
25+
- name: Check frontend code formatting
26+
run: |
27+
cd components/crud-web-apps/common/frontend/kubeflow-common-lib
28+
npm i
29+
npm run format:check
30+
31+
- name: Check frontend code linting
32+
run: |
33+
cd components/crud-web-apps/common/frontend/kubeflow-common-lib
34+
npm i
35+
npm run lint-check
36+
37+
frontend-unit-tests:
38+
runs-on: ubuntu-22.04
39+
name: Unit tests
40+
steps:
41+
- name: Checkout
42+
uses: actions/checkout@v4
43+
44+
- name: Setup node version to 16
45+
uses: actions/setup-node@v4
46+
with:
47+
node-version: 16
48+
49+
- name: Install Kubeflow common library dependecies
50+
run: |
51+
cd components/crud-web-apps/common/frontend/kubeflow-common-lib
52+
npm i
53+
npm run test:prod

.github/workflows/python_lint.yaml

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
name: Python Linting
2+
3+
on:
4+
pull_request:
5+
branches:
6+
- v*-branch
7+
- notebooks-v1
8+
paths:
9+
- "**.py"
10+
11+
jobs:
12+
flake8-lint:
13+
runs-on: ubuntu-22.04
14+
name: Check
15+
steps:
16+
- name: Checkout source repository
17+
uses: actions/checkout@v4
18+
19+
- name: Set up Python environment 3.8
20+
uses: actions/setup-python@v5
21+
with:
22+
python-version: "3.8"
23+
24+
- name: flake8 Lint
25+
uses: py-actions/flake8@v2
26+
with:
27+
exclude: "docs"

components/crud-web-apps/common/frontend/kubeflow-common-lib/projects/kubeflow/src/test.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
// just for the frontend test, will be removed after it passed.
12
// This file is required by karma.conf.js and loads recursively all the .spec and framework files
23

34
import 'zone.js';

components/crud-web-apps/jupyter/backend/apps/common/form.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
# just for the lint test, will be removed after it passed.
12
import json
23

34
from kubeflow.kubeflow.crud_backend import logging

0 commit comments

Comments
 (0)