From b4b94276add81b866b7712dd543b0b0b6873dacf Mon Sep 17 00:00:00 2001 From: Andy Stoneberg Date: Fri, 5 Sep 2025 10:17:41 -0400 Subject: [PATCH] fix: update supported platforms for multi-arch builds After discussion with the Kubeflow WG lead - concerns were raised about including `linux/s390x` support in our multi-arch builds for the following reasons: - not clear we could in good faith support this system due to lack of hardware / potential emulation issues - not clear there is enough of a need from community to support `linux/s390x` for Kubeflow Notebooks. As a result - we are going to remove the `linux/s390x` target from our multi-arch builds logic. Additionally, included a minor fix to explicitly specify the `v8` variant of `linux/arm64`. Today `linux/arm64` and `linux/arm64/v8` are essentially the same - but that could change if there was ever a `v9` variant introduced. As such - opting to be explicit here. Signed-off-by: Andy Stoneberg --- workspaces/backend/Makefile | 2 +- workspaces/controller/Makefile | 2 +- workspaces/frontend/Makefile | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/workspaces/backend/Makefile b/workspaces/backend/Makefile index ed264a7ad..838996ed9 100644 --- a/workspaces/backend/Makefile +++ b/workspaces/backend/Makefile @@ -104,7 +104,7 @@ docker-push: ## Push docker image with the backend. # - have enabled BuildKit. More info: https://docs.docker.com/develop/develop-images/build_enhancements/ # - be able to push the image to your registry (i.e. if you do not set a valid value via IMG=> then the export will fail) # To adequately provide solutions that are compatible with multiple platforms, you should consider using this option. -PLATFORMS ?= linux/arm64,linux/amd64,linux/s390x,linux/ppc64le +PLATFORMS ?= linux/arm64/v8,linux/amd64,linux/ppc64le .PHONY: docker-buildx docker-buildx: ## Build and push docker image for the manager for cross-platform support # copy existing Dockerfile and insert --platform=${BUILDPLATFORM} into Dockerfile.cross, and preserve the original Dockerfile diff --git a/workspaces/controller/Makefile b/workspaces/controller/Makefile index 6032c8c91..64d6b99ed 100644 --- a/workspaces/controller/Makefile +++ b/workspaces/controller/Makefile @@ -114,7 +114,7 @@ docker-push: ## Push docker image with the manager. # - have enabled BuildKit. More info: https://docs.docker.com/develop/develop-images/build_enhancements/ # - be able to push the image to your registry (i.e. if you do not set a valid value via IMG=> then the export will fail) # To adequately provide solutions that are compatible with multiple platforms, you should consider using this option. -PLATFORMS ?= linux/arm64,linux/amd64,linux/s390x,linux/ppc64le +PLATFORMS ?= linux/arm64/v8,linux/amd64,linux/ppc64le .PHONY: docker-buildx docker-buildx: ## Build and push docker image for the manager for cross-platform support # copy existing Dockerfile and insert --platform=${BUILDPLATFORM} into Dockerfile.cross, and preserve the original Dockerfile diff --git a/workspaces/frontend/Makefile b/workspaces/frontend/Makefile index a7758ae50..cc5ef28de 100755 --- a/workspaces/frontend/Makefile +++ b/workspaces/frontend/Makefile @@ -39,7 +39,7 @@ docker-push: ## Push docker image for the frontend. $(CONTAINER_TOOL) push ${IMG} # PLATFORMS defines the target platforms for cross-platform support. -PLATFORMS ?= linux/arm64,linux/amd64,linux/s390x,linux/ppc64le +PLATFORMS ?= linux/arm64/v8,linux/amd64,linux/ppc64le .PHONY: docker-buildx docker-buildx: ## Build and push docker image for cross-platform support.